From: Alban Browaeys <alban.browaeys@gmail•com>
To: Gustavo Padovan <gustavo.padovan@collabora•co.uk>,
Inki Dae <inki.dae@samsung•com>,
Joonyoung Shim <jy0922.shim@samsung•com>,
Seung-Woo Kim <sw0312.kim@samsung•com>,
Kyungmin Park <kyungmin.park@samsung•com>
Cc: linux-samsung-soc@vger•kernel.org, linux-next@vger•kernel.org,
Alban Browaeys <prahal@yahoo•com>
Subject: [PATCH] exynos/drm: fix no hdmi output
Date: Thu, 29 Jan 2015 22:18:40 +0100 [thread overview]
Message-ID: <1422566320-6126-1-git-send-email-prahal@yahoo.com> (raw)
The hdmi outputs black screen only even though under the hood Xorg and
framebuffer console are fine : devices found and initialized, but
not a pixel out.
Commit 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
changed the call order of mixer_initialize with regards to
exynos_drm_crtc_create.
This changes breaks hdmi out on Odroid U2 (linux-next with added
Marek Szyprowski v4 hdmi patchset from linux-samsung-soc ML).
Restore the previous call ordering get hdmi to ouput proper pixels:
ie call mixer_initialize first then exynos_drm_crtc_create.
Fixes: 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
Signed-off-by: Alban Browaeys <prahal@yahoo•com>
---
drivers/gpu/drm/exynos/exynos_mixer.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index d8fd8e1..188f90f 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -1258,18 +1258,19 @@ static int mixer_bind(struct device *dev, struct device *manager, void *data)
struct drm_device *drm_dev = data;
int ret;
+ ret = mixer_initialize(ctx, drm_dev);
+ if (ret)
+ return ret;
+
ctx->crtc = exynos_drm_crtc_create(drm_dev, ctx->pipe,
EXYNOS_DISPLAY_TYPE_HDMI,
&mixer_crtc_ops, ctx);
if (IS_ERR(ctx->crtc)) {
+ mixer_ctx_remove(ctx);
ret = PTR_ERR(ctx->crtc);
goto free_ctx;
}
- ret = mixer_initialize(ctx, drm_dev);
- if (ret)
- goto free_ctx;
-
return 0;
free_ctx:
--
2.1.4
next reply other threads:[~2015-01-29 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 21:18 Alban Browaeys [this message]
2015-01-30 0:24 ` [PATCH] exynos/drm: fix no hdmi output Joonyoung Shim
2015-01-30 7:29 ` Joonyoung Shim
2015-01-30 14:55 ` Gustavo Padovan
2015-02-04 8:35 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422566320-6126-1-git-send-email-prahal@yahoo.com \
--to=alban.browaeys@gmail$(echo .)com \
--cc=gustavo.padovan@collabora$(echo .)co.uk \
--cc=inki.dae@samsung$(echo .)com \
--cc=jy0922.shim@samsung$(echo .)com \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=prahal@yahoo$(echo .)com \
--cc=sw0312.kim@samsung$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox