public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm•com>
To: linux-kernel@vger•kernel.org,
	Russell King <linux@arm•linux.org.uk>,
	linux-arm-kernel@lists•infradead.org
Cc: Sudeep Holla <sudeep.holla@arm•com>,
	linux-next@vger•kernel.org,
	Stephen Rothwell <sfr@canb•auug.org.au>,
	Daniel Lezcano <daniel.lezcano@linaro•org>,
	Thomas Gleixner <tglx@linutronix•de>
Subject: [PATCH] clocksource: make ARM_TIMER_SP804 depend on GENERIC_SCHED_CLOCK
Date: Fri, 29 May 2015 09:17:56 +0100	[thread overview]
Message-ID: <1432887476-19301-1-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <20150529110919.2276365a@canb.auug.org.au>

Commit 5261ef2ea836 ("ARM: 8366/1: move Dual-Timer SP804 driver to
drivers/clocksource") moved SP804 to drivers/clocksource resulting in
it being selectable on platforms/architectures without the config
GENERIC_SCHED_CLOCK enabled. Due to that, it results in the following
build failure(e.g. x86_64 allmodconfig)

drivers/built-in.o: In function `__sp804_clocksource_and_sched_clock_init':
(.init.text+0x1a0e7): undefined reference to `sched_clock_register'

This patch fixes the build by making ARM_TIMER_SP804 depend on
GENERIC_SCHED_CLOCK

Cc: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Russell King <linux@arm•linux.org.uk>
Cc: Daniel Lezcano <daniel.lezcano@linaro•org>
Cc: Thomas Gleixner <tglx@linutronix•de>
Signed-off-by: Sudeep Holla <sudeep.holla@arm•com>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Hi Russell,

If you are fine with this fix, I will put this into the patch tracker.

Regards,
Sudeep

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 0f1c0e7f86da..50534704486a 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -134,6 +134,7 @@ config ARM_GLOBAL_TIMER

 config ARM_TIMER_SP804
 	bool "Support for Dual Timer SP804 module"
+	depends on GENERIC_SCHED_CLOCK
 	select CLKSRC_MMIO
 	select CLKSRC_OF if OF

--
1.9.1

  reply	other threads:[~2015-05-29  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29  1:09 linux-next: build failure after merge of the arm tree Stephen Rothwell
2015-05-29  8:17 ` Sudeep Holla [this message]
2015-05-29 11:33   ` [PATCH] clocksource: make ARM_TIMER_SP804 depend on GENERIC_SCHED_CLOCK Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432887476-19301-1-git-send-email-sudeep.holla@arm.com \
    --to=sudeep.holla@arm$(echo .)com \
    --cc=daniel.lezcano@linaro$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux@arm$(echo .)linux.org.uk \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=tglx@linutronix$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox