From: Joachim Eastwood <manabian@gmail•com>
To: olof@lixom•net, arm@kernel•org
Cc: broonie@kernel•org, kernel-build-reports@lists•linaro.org,
linaro-kernel@lists•linaro.org, linux-next@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
Joachim Eastwood <manabian@gmail•com>
Subject: [PATCH] memory: pl172: fix modular build
Date: Thu, 23 Jul 2015 00:10:37 +0200 [thread overview]
Message-ID: <1437603037-18395-1-git-send-email-manabian@gmail.com> (raw)
In-Reply-To: <20150722184345.GB11162@sirena.org.uk>
Building pl172 as a module fails with:
> ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined!
Because the symbol of_default_bus_match_table isn't exported by the OF
core code so can't be referenced from modules. Fix this by removing
the usage of of_default_bus_match_table for now. The side effect of
this is that child nodes can't use "simple-bus" or "simple-mfd".
Reported-by: Mark Brown <broonie@kernel•org>
Signed-off-by: Joachim Eastwood <manabian@gmail•com>
---
This should fix the allmod build failure introduces by the
pl172 driver that Mark encountered. After this fix the driver
should builds just fine as a module and there is no behavior
change when boot my devkit either since none of children under
pl172 uses "simple-bus/mfd" right now.
drivers/memory/pl172.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/memory/pl172.c b/drivers/memory/pl172.c
index 3a8e57ee96f0..b2ef6072fbf4 100644
--- a/drivers/memory/pl172.c
+++ b/drivers/memory/pl172.c
@@ -255,8 +255,7 @@ static int pl172_probe(struct amba_device *adev, const struct amba_id *id)
if (ret)
continue;
- of_platform_populate(child_np, of_default_bus_match_table,
- NULL, dev);
+ of_platform_populate(child_np, NULL, NULL, dev);
}
return 0;
--
1.8.0
next prev parent reply other threads:[~2015-07-22 22:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 14:30 next-20150722 build: 2 failures 75 warnings (next-20150722) Build bot for Mark Brown
2015-07-22 18:40 ` Mark Brown
2015-07-22 19:43 ` [PATCH] genirq: Export irq_{get,set}_irqchip_state() Bjorn Andersson
2015-07-24 10:53 ` Mark Brown
2015-07-27 13:23 ` Linus Walleij
2015-07-28 18:49 ` Thomas Gleixner
2015-07-22 18:43 ` next-20150722 build: 2 failures 75 warnings (next-20150722) Mark Brown
2015-07-22 21:26 ` Joachim Eastwood
2015-07-23 15:54 ` Rob Herring
2015-07-22 22:10 ` Joachim Eastwood [this message]
2015-07-22 23:10 ` [PATCH] memory: pl172: fix modular build Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437603037-18395-1-git-send-email-manabian@gmail.com \
--to=manabian@gmail$(echo .)com \
--cc=arm@kernel$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=kernel-build-reports@lists$(echo .)linaro.org \
--cc=linaro-kernel@lists$(echo .)linaro.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=olof@lixom$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox