From: David Howells <dhowells@redhat•com>
To: Michal Simek <monstr@monstr•eu>
Cc: dhowells@redhat•com, linux-next@vger•kernel.org,
LKML <linux-kernel@vger•kernel.org>,
Arnd Bergmann <arnd@arndb•de>
Subject: Re: Add #includes needed to permit the removal of asm/system.h - sha1 96f951edb1f1bdbbc99b0cd458f9808bb83d58ae
Date: Thu, 03 Jan 2013 16:35:17 +0000 [thread overview]
Message-ID: <14685.1357230917@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHTX3d+P_UQK8nPfN8BKLdTkVY2VMKhty1rkCKbfHCrQBa+Nyw@mail.gmail.com>
Michal Simek <monstr@monstr•eu> wrote:
> It is because microblaze uses cmpxchg_local which is defined
> asm-generic/atomic.h file.
> Arnds patch has added it to atomic.h
> asm-generic: add generic atomic.h and io.h
> (sha1: 3f7e212df82ca0459d44c91d9e019efd1b5f936c)
>
> What about to move cmpxchg_local and cmpxchg64_local from atomic.h to
> cmpxchg-local.h?
Hmmm... cmpxchg_local() should be obtained through asm/cmpxchg.h, not
asm/atomic.h. See:
grep -r define\\s*cmpxchg_local arch
David
next prev parent reply other threads:[~2013-01-03 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 12:32 Add #includes needed to permit the removal of asm/system.h - sha1 96f951edb1f1bdbbc99b0cd458f9808bb83d58ae Michal Simek
2013-01-03 16:35 ` David Howells [this message]
2013-01-04 11:41 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14685.1357230917@warthog.procyon.org.uk \
--to=dhowells@redhat$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=monstr@monstr$(echo .)eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox