From: "Paul E. McKenney" <paulmck@kernel•org>
To: Jason Gunthorpe <jgg@nvidia•com>
Cc: Dave Jiang <dave.jiang@intel•com>,
Dan Williams <dan.j.williams@intel•com>,
linux-cxl@vger•kernel.org, dave@stgolabs•net,
jonathan.cameron@huawei•com, alison.schofield@intel•com,
vishal.l.verma@intel•com, ira.weiny@intel•com, gourry@gourry•net,
linux-kernel@vger•kernel.org, linux-next@vger•kernel.org,
sfr@canb•auug.org.au
Subject: Re: [BUG -next] ./usr/include/cxl/features.h:11:10: fatal error: uuid/uuid.h: No such file or directory
Date: Mon, 31 Mar 2025 09:48:53 -0700 [thread overview]
Message-ID: <16f87249-053a-4779-92dd-38a9679eeaee@paulmck-laptop> (raw)
In-Reply-To: <20250331132439.GD10839@nvidia.com>
On Mon, Mar 31, 2025 at 10:24:39AM -0300, Jason Gunthorpe wrote:
> On Fri, Mar 28, 2025 at 05:26:42PM -0700, Dave Jiang wrote:
> > > For now the following builds for me, but it is a quite a mess to undo
> > > the assumption that that the hardware object definitions can not use
> > > uuid_t:
> >
> > +Jason.
>
> Seems invasive?
>
> Maybe just like below?
I tried testing this, but was not able to work out what it applies to.
If you let me know, I will give it a try.
Thanx, Paul
> Dave please send a patch for whatever is good..
>
> diff --git a/include/uapi/cxl/features.h b/include/uapi/cxl/features.h
> index d6db8984889fa6..e31862dfc2eda0 100644
> --- a/include/uapi/cxl/features.h
> +++ b/include/uapi/cxl/features.h
> @@ -8,10 +8,16 @@
> #define _UAPI_CXL_FEATURES_H_
>
> #include <linux/types.h>
> -#ifndef __KERNEL__
> -#include <uuid/uuid.h>
> -#else
> +
> +typedef struct {
> + __u8 b[16];
> +} __kernel_uuid_t;
> +
> +#ifdef __KERNEL__
> #include <linux/uuid.h>
> +static_assert(sizeof(__kernel_uuid_t) == sizeof(uuid_t) &&
> + __alignof__(__kernel_uuid_t) == __alignof__(uuid_t));
> +#define __kernel_uuid_t uuid_t
> #endif
>
> /*
> @@ -60,7 +66,7 @@ struct cxl_mbox_get_sup_feats_in {
> * Get Supported Features Supported Feature Entry
> */
> struct cxl_feat_entry {
> - uuid_t uuid;
> + __kernel_uuid_t uuid;
> __le16 id;
> __le16 get_feat_size;
> __le16 set_feat_size;
> @@ -110,7 +116,7 @@ struct cxl_mbox_get_sup_feats_out {
> * CXL spec r3.2 section 8.2.9.6.2 Table 8-99
> */
> struct cxl_mbox_get_feat_in {
> - uuid_t uuid;
> + __kernel_uuid_t uuid;
> __le16 offset;
> __le16 count;
> __u8 selection;
> @@ -143,7 +149,7 @@ enum cxl_get_feat_selection {
> */
> struct cxl_mbox_set_feat_in {
> __struct_group(cxl_mbox_set_feat_hdr, hdr, /* no attrs */,
> - uuid_t uuid;
> + __kernel_uuid_t uuid;
> __le32 flags;
> __le16 offset;
> __u8 version;
>
next prev parent reply other threads:[~2025-03-31 16:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 17:39 [BUG -next] ./usr/include/cxl/features.h:11:10: fatal error: uuid/uuid.h: No such file or directory Paul E. McKenney
2025-03-28 20:03 ` Dave Jiang
2025-03-28 20:45 ` Paul E. McKenney
2025-03-28 21:22 ` Dave Jiang
2025-03-28 21:57 ` Paul E. McKenney
2025-03-28 23:26 ` Dan Williams
2025-03-28 23:58 ` Paul E. McKenney
2025-03-29 0:23 ` Dan Williams
2025-03-29 0:26 ` Dave Jiang
2025-03-31 13:24 ` Jason Gunthorpe
2025-03-31 16:48 ` Paul E. McKenney [this message]
2025-03-31 16:54 ` Dan Williams
2025-03-31 17:17 ` Jason Gunthorpe
2025-03-31 19:47 ` Dan Williams
2025-04-01 7:01 ` Venkat Rao Bagalkote
2025-04-01 14:08 ` Paul E. McKenney
2025-04-01 15:15 ` Dave Jiang
2025-04-02 0:07 ` Paul E. McKenney
2025-04-02 0:18 ` Dave Jiang
2025-04-02 0:47 ` Stephen Rothwell
2025-04-02 4:21 ` Paul E. McKenney
2025-04-02 6:27 ` Venkat Rao Bagalkote
2025-04-02 11:44 ` Jason Gunthorpe
2025-04-02 13:42 ` Venkat Rao Bagalkote
2025-04-02 17:20 ` Paul E. McKenney
2025-04-07 17:49 ` Jason Gunthorpe
2025-04-05 17:34 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16f87249-053a-4779-92dd-38a9679eeaee@paulmck-laptop \
--to=paulmck@kernel$(echo .)org \
--cc=alison.schofield@intel$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.jiang@intel$(echo .)com \
--cc=dave@stgolabs$(echo .)net \
--cc=gourry@gourry$(echo .)net \
--cc=ira.weiny@intel$(echo .)com \
--cc=jgg@nvidia$(echo .)com \
--cc=jonathan.cameron@huawei$(echo .)com \
--cc=linux-cxl@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=vishal.l.verma@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox