Subject: Re: linux-next: md tree build failure

From: Neil Brown <[email-masked]>
Date: Wed, 15 Oct 2008 21:55:12 +1100

On Wednesday October 15, [email-masked] wrote:
> Hi Neil,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> drivers/md/raid1.c: In function 'sync_request':
> drivers/md/raid1.c:1759: error: implicit declaration of function 'msleep_interruptible'
> make[3]: *** [drivers/md/raid1.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> drivers/md/raid10.c: In function 'sync_request':
> drivers/md/raid10.c:1749: error: implicit declaration of function 'msleep_interruptible'
> make[3]: *** [drivers/md/raid10.o] Error 1
> drivers/md/md.c: In function 'md_do_sync':
> drivers/md/md.c:5915: error: implicit declaration of function 'msleep'
> 
> Caused by commit 6caa3b0bbdb474647f6bdd8a958ffc46f78d8d58 ("md: Remove
> unnecessary #includes, #defines, and function declarations").  I added
> the following patch.

Thanks.  I had heard of this problem in -mm but as I couldn't
reproduce it I thought it might be -mm specific and held off taking
the patch.
I'll add it to my tree now.

Thanks,
NeilBrown

> 
> -- 
> Cheers,
> Stephen Rothwell                    [email-masked]
> http://www.canb.auug.org.au/~sfr/
> 
> From: Stephen Rothwell <[email-masked]>
> Date: Wed, 15 Oct 2008 20:05:50 +1100
> Subject: [PATCH] md: msleep need include of linux/delay.h
> 
> Signed-off-by: Stephen Rothwell <[email-masked]>
> ---
>  drivers/md/md.c     |    1 +
>  drivers/md/raid1.c  |    1 +
>  drivers/md/raid10.c |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 4c89836..abc82f2 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -45,6 +45,7 @@
>  #include <linux/random.h>
>  #include <linux/reboot.h>
>  #include <linux/file.h>
> +#include <linux/delay.h>
>  
>  #define MAJOR_NR MD_MAJOR
>  
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index b976442..9c788e2 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -32,6 +32,7 @@
>   */
>  
>  #include "dm-bio-list.h"
> +#include <linux/delay.h>
>  #include <linux/raid/raid1.h>
>  #include <linux/raid/bitmap.h>
>  
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 8bdc9bf..7d7f345 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -19,6 +19,7 @@
>   */
>  
>  #include "dm-bio-list.h"
> +#include <linux/delay.h>
>  #include <linux/raid/raid10.h>
>  #include <linux/raid/bitmap.h>
>  
> -- 
> 1.5.6.5