From: "Vegard Nossum" <vegard.nossum@gmail•com>
To: David Howells <dhowells@redhat•com>
Cc: jay kumar <jaykumarks@gmail•com>,
linux-kernel@vger•kernel.org, linux-next@vger•kernel.org
Subject: Re: Bug: "bad unlock balance detected" 2.6.27-rc3-next-20080820
Date: Fri, 22 Aug 2008 15:56:24 +0200 [thread overview]
Message-ID: <19f34abd0808220656x42006849ta29c423beb6bb7d4@mail.gmail.com> (raw)
In-Reply-To: <24926.1219410297@redhat.com>
On Fri, Aug 22, 2008 at 3:04 PM, David Howells <dhowells@redhat•com> wrote:
>> I couldn't reproduce your original failure, but I've attempted to fix
>> it by reordering the mutex unlock and bprm free and removing the
>> extraneous unlock (see attached patch; it boots for me without
>> errors).
>
> Your patch ought to throw up its own lock failure. You've added a
> mutex_unlock() call to the execve success path, but you haven't removed one
> from install_exec_creds(). Also, this patch is not sufficient as it doesn't
> do anything for compat_do_execve().
Ah, right. Thanks for the review anyway :-)
I didn't realize the lock should be held across the function call, I
will do a bit more research next time :-)
It seems to be a bit tricky. It would probably be nice to have
somebody else look at it too and verify that it is now indeed correct?
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
prev parent reply other threads:[~2008-08-22 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6f31812b0808210004i63b3273ehf65ce9eb139256f0@mail.gmail.com>
2008-08-21 8:10 ` Bug: "bad unlock balance detected" 2.6.27-rc3-next-20080820 Vegard Nossum
2008-08-21 8:19 ` Vegard Nossum
2008-08-21 18:54 ` Kamalesh Babulal
2008-08-22 13:04 ` David Howells
2008-08-22 13:56 ` Vegard Nossum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0808220656x42006849ta29c423beb6bb7d4@mail.gmail.com \
--to=vegard.nossum@gmail$(echo .)com \
--cc=dhowells@redhat$(echo .)com \
--cc=jaykumarks@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox