From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail•com>
Cc: linux-next@vger•kernel.org
Subject: linux-next: ide build failure
Date: Fri, 30 May 2008 11:54:22 +1000 [thread overview]
Message-ID: <20080530115422.989d9ab6.sfr@canb.auug.org.au> (raw)
Hi Bart,
Today's linux-next build (x86_64 allmodconfig) failed like this:
ERROR: "ide_timing_merge" [drivers/ide/pci/via82cxxx.ko] undefined!
ERROR: "ide_timing_compute" [drivers/ide/pci/via82cxxx.ko] undefined!
ERROR: "ide_timing_find_mode" [drivers/ide/pci/opti621.ko] undefined!
ERROR: "ide_timing_find_mode" [drivers/ide/pci/cy82c693.ko] undefined!
ERROR: "ide_timing_find_mode" [drivers/ide/pci/cmd64x.ko] undefined!
ERROR: "ide_timing_find_mode" [drivers/ide/pci/cmd640.ko] undefined!
ERROR: "ide_timing_merge" [drivers/ide/pci/amd74xx.ko] undefined!
ERROR: "ide_timing_compute" [drivers/ide/pci/amd74xx.ko] undefined!
ERROR: "ide_timing_find_mode" [drivers/ide/pci/alim15x3.ko] undefined!
Caused by commit 3a3147040f2bb250ca09cd5ce5b0526969d50ba6 ("ide: convert
ide-timing.h to ide-timings.c library").
I applied the following patch.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
>From 0a1194cf0893e6e9ad0ecd9ade50f710c0540552 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Fri, 30 May 2008 11:52:22 +1000
Subject: [PATCH] ide: ide-timing.h fallout
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/ide/ide-timings.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/ide/ide-timings.c b/drivers/ide/ide-timings.c
index dca53b0..8a43bd9 100644
--- a/drivers/ide/ide-timings.c
+++ b/drivers/ide/ide-timings.c
@@ -24,6 +24,7 @@
#include <linux/kernel.h>
#include <linux/hdreg.h>
#include <linux/ide.h>
+#include <linux/module.h>
/*
* PIO 0-5, MWDMA 0-2 and UDMA 0-6 timings (in nanoseconds).
@@ -73,6 +74,7 @@ struct ide_timing *ide_timing_find_mode(u8 speed)
return NULL;
return t;
}
+EXPORT_SYMBOL(ide_timing_find_mode);
u16 ide_pio_cycle_time(ide_drive_t *drive, u8 pio)
{
@@ -131,6 +133,7 @@ void ide_timing_merge(struct ide_timing *a, struct ide_timing *b,
if (what & IDE_TIMING_UDMA)
m->udma = max(a->udma, b->udma);
}
+EXPORT_SYMBOL(ide_timing_merge);
int ide_timing_compute(ide_drive_t *drive, u8 speed,
struct ide_timing *t, int T, int UT)
@@ -199,3 +202,4 @@ int ide_timing_compute(ide_drive_t *drive, u8 speed,
return 0;
}
+EXPORT_SYMBOL(ide_timing_compute);
--
1.5.5.2
next reply other threads:[~2008-05-30 1:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 1:54 Stephen Rothwell [this message]
2008-05-31 13:38 ` linux-next: ide build failure Bartlomiej Zolnierkiewicz
2008-06-01 2:05 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2008-06-16 3:38 Stephen Rothwell
2008-06-16 3:55 ` Benjamin Herrenschmidt
2008-06-16 9:54 ` Bartlomiej Zolnierkiewicz
2008-06-16 19:24 ` Bartlomiej Zolnierkiewicz
2008-06-16 22:40 ` Benjamin Herrenschmidt
2008-06-17 9:53 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080530115422.989d9ab6.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=bzolnier@gmail$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox