From: Adrian Bunk <bunk@kernel•org>
To: David Woodhouse <dwmw2@infradead•org>
Cc: Segher Boessenkool <segher@kernel•crashing.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>,
LKML <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org, Andy Whitcroft <apw@shadowen•org>
Subject: Re: [BUILD-FAILURE] linux-next: Tree for June 4 - firmware/keyspan/mpr.fw.gen.S
Date: Wed, 4 Jun 2008 21:20:11 +0300 [thread overview]
Message-ID: <20080604182011.GD4189@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <1212601930.32207.134.camel@pmac.infradead.org>
On Wed, Jun 04, 2008 at 06:52:10PM +0100, David Woodhouse wrote:
> On Wed, 2008-06-04 at 19:19 +0200, Segher Boessenkool wrote:
> > It is a new feature in GNU make 3.81, which was released slightly
> > over two years ago.
>
> Hm, Ok. I'll stick in a workaround. Thanks.
>
> diff --git a/firmware/Makefile b/firmware/Makefile
> index b4f758a..166a9b0 100644
> --- a/firmware/Makefile
> +++ b/firmware/Makefile
> @@ -83,6 +83,13 @@ wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \
> include/config/superh32.h include/config/superh64.h \
> include/config/x86_32.h include/config/x86_64.h)
>
> +# Workaround for ancient versions of make, where .SECONDEXPANSION doesn't work.
Can you write make < 3.81 instead?
We do know the version and this will make it easier in a few years to
determine when the workaround will no longer be required.
> +# It'll end up depending on these targets, so make them a PHONY rule which
> +# depends on _all_ the directories in $(firmware-dirs), and it'll work out OK.
> +PHONY += $(objtree)/$$(%) $(objtree)/$(obj)/$$(%)
> +$(objtree)/$$(%) $(objtree)/$(obj)/$$(%): $(firmware-dirs)
> + @true
> +
> # For the $$(dir %) trick, where we need % to be expanded first.
> .SECONDEXPANSION:
>
> dwmw2
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-06-04 18:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 8:00 linux-next: Tree for June 4 Stephen Rothwell
2008-06-04 11:46 ` [BUILD-FAILURE] linux-next: Tree for June 4 - firmware/keyspan/mpr.fw.gen.S Kamalesh Babulal
2008-06-04 11:50 ` David Woodhouse
2008-06-04 11:57 ` David Woodhouse
2008-06-04 17:19 ` Segher Boessenkool
2008-06-04 17:52 ` David Woodhouse
2008-06-04 18:20 ` Adrian Bunk [this message]
2008-06-04 21:33 ` David Woodhouse
2008-06-04 21:37 ` Adrian Bunk
2008-06-05 9:43 ` Kamalesh Babulal
2008-06-04 13:38 ` David Woodhouse
2008-06-05 9:13 ` Sam Ravnborg
2008-06-05 9:15 ` David Woodhouse
2008-06-05 10:44 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080604182011.GD4189@cs181133002.pp.htv.fi \
--to=bunk@kernel$(echo .)org \
--cc=apw@shadowen$(echo .)org \
--cc=dwmw2@infradead$(echo .)org \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=segher@kernel$(echo .)crashing.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox