From: Greg KH <greg@kroah•com>
To: Nigel Cunningham <nigel@tuxonice•net>
Cc: linux-kernel@vger•kernel.org, devel@linuxdriverproject•org,
kernel-janitors@vger•kernel.org, linux-next@vger•kernel.org,
Stephen Rothwell <sfr@canb•auug.org.au>
Subject: Re: [ANNOUNCE] linux-staging tree created
Date: Wed, 11 Jun 2008 09:24:14 -0700 [thread overview]
Message-ID: <20080611162414.GB22134@kroah.com> (raw)
In-Reply-To: <1213156812.16146.37.camel@nigel-laptop>
On Wed, Jun 11, 2008 at 02:00:12PM +1000, Nigel Cunningham wrote:
> Hi Greg.
>
> On Tue, 2008-06-10 at 20:29 -0700, Greg KH wrote:
> > On Wed, Jun 11, 2008 at 11:05:46AM +1000, Nigel Cunningham wrote:
> > > Hi.
> > >
> > > Would you consider including TuxOnIce in it?
> > >
> > > I do still want to get it merged and would appreciate feedback.
> >
> > Is the patch "stand-alone", only adding new code in discrete chunks like
> > a new driver or filesystem would?
>
> The patch I distribute now does have a few parts to it that could be
> separated into distinct patches (cryptoapi LZF support, fuse freezer
> support), but the bulk of it is TuxOnIce itself, which just adds new
> files and inserts the hooks necessary to share the lowlevel code with
> [u]swsusp. I think, therefore, it would akin to adding a new driver or
> filesystem.
>
> > If not, I don't think it is relevant. Odds are you want to be your own
> > series of patches, like we discussed years ago, right?
>
> I don't think I do want to have my own series of patches, because
> TuxOnIce doesn't remove or rework swsusp or uswsusp, but sits along side
> them. I'm not trying to mutate swsusp into TuxOnIce, because that would
> require a complete rework of swsusp from the ground up (TuxOnIce does
> everything but the atomic copy/restore and associated prep/cleanup
> differently).
Like always, you need to divide your changes up into logical chunks in
order to get them approved and reviewed. For such a core functionality
like suspend, this is extra important.
I do not think that -staging is proper for this kind of feature at this
point in time.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@vger•kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-11 16:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 19:05 [ANNOUNCE] linux-staging tree created Greg KH
2008-06-10 19:06 ` linux-staging status for June 10, 2008 Greg KH
2008-06-10 22:52 ` [ANNOUNCE] linux-staging tree created Theodore Tso
2008-06-10 23:05 ` Greg KH
2008-06-11 0:07 ` Felipe Balbi
2008-06-11 3:28 ` Greg KH
2008-06-11 1:05 ` Nigel Cunningham
2008-06-11 3:29 ` Greg KH
2008-06-11 4:00 ` Nigel Cunningham
2008-06-11 16:24 ` Greg KH [this message]
2008-06-11 4:03 ` Template of what you're after? (Was [ANNOUNCE] linux-staging tree created) Nigel Cunningham
2008-06-11 16:23 ` Greg KH
2008-06-11 9:27 ` [ANNOUNCE] linux-staging tree created Benny Halevy
2008-06-11 9:50 ` Boaz Harrosh
2008-06-11 9:58 ` Felipe Balbi
2008-06-11 16:25 ` Greg KH
2008-06-11 17:43 ` Boaz Harrosh
2008-06-11 16:25 ` Greg KH
2008-06-11 10:45 ` Will Newton
2008-06-11 16:26 ` Greg KH
2008-06-12 11:37 ` Will Newton
2008-06-12 23:54 ` Greg KH
2008-06-13 14:14 ` Luis R. Rodriguez
2008-06-13 14:33 ` John W. Linville
2008-06-13 15:51 ` Luis R. Rodriguez
[not found] ` <20080613143328.GA16506-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2008-06-14 0:28 ` Greg KH
[not found] ` <43e72e890806130714k535b041evaf750209ea492c47-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-06-14 0:27 ` Greg KH
2008-06-17 12:51 ` Pavel Machek
2008-07-02 23:11 ` Greg KH
2008-07-14 2:50 ` Jike Song
2008-07-14 2:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611162414.GB22134@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=devel@linuxdriverproject$(echo .)org \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=nigel@tuxonice$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox