Subject: Re: linux-next: rr tree build failure

From: Christian Borntraeger <[email-masked]>
Date: Wed, 25 Jun 2008 09:35:54 +0200

Am Mittwoch, 25. Juni 2008 schrieb Stephen Rothwell:
> Hi Rusty,
> 
> Today's linux-next build (x86_64 allmodconfig (CONFIG_VIRTIO_CONSOLE=y,
> CONFIG_VIRTIO=m)) failed like this:

That is interesting. VIRTIO_CONSOLE (=y) has a depends on VIRTIO(m). Seems 
that Kconfig thinks that m is enough to fulfil a depends on.

Rusty, what do you think about the following fixup patch? (please fold it into 
the other one):

---
 drivers/char/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/char/Kconfig
===================================================================
--- linux-2.6.orig/drivers/char/Kconfig
+++ linux-2.6/drivers/char/Kconfig
@@ -635,7 +635,7 @@ config HVC_XEN
 
 config VIRTIO_CONSOLE
 	bool "Virtio console"
-	depends on VIRTIO
+	select VIRTIO
 	select HVC_DRIVER
 	help
 	  Virtio console for use with lguest and other hypervisors.