public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public•gmane.org>
To: David Woodhouse
	<david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>,
	linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public•gmane.org>,
	kernel-testers-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
	Ingo Molnar <mingo-X9Un+BFzKDI@public•gmane.org>,
	Jaswinder Singh
	<jaswinder-wEGCiKHe2LqWVfeAwA7xHQ@public•gmane.org>,
	"Maciej W. Rozycki"
	<macro-6z/3iImG2C8G8FEW9MqTrA@public•gmane.org>
Subject: Re: linux-next: Tree for June 26
Date: Sat, 28 Jun 2008 01:04:16 +0200	[thread overview]
Message-ID: <200806280104.17527.rjw@sisk.pl> (raw)
In-Reply-To: <1214563913.10393.180.camel-ZP4jZrcIevRpWr+L1FloEB2eb7JE58TQ@public.gmane.org>

On Friday, 27 of June 2008, David Woodhouse wrote:
> On Fri, 2008-06-27 at 01:38 +0200, Rafael J. Wysocki wrote:
> > commit 423c982fffb1cd95c8cdd654ce5ab59351ba41f5
> > Author: Jaswinder Singh <jaswinder-wEGCiKHe2LqWVfeAwA7xHQ@public•gmane.org>
> > Date:   Wed Jun 18 19:58:33 2008 +0530
> > 
> >     firmware: convert tg3 driver to request_firmware()
> > 
> > breaks my nx6325.
> > 
> > Apparently, with this patch applied the tg3 has a NULL pointer dereference
> > somewhere, but I can only see the first line of the oops, afterwards the box
> > hangs solid.
> 
> That's a 5705, isn't it? So using the 'tso5' firmware?
> 
> Is that firmware available (did you either build it into your kernel, or
> run 'make INSTALL_FW_PATH=/lib/firmware firmware_install')? 

I built it into the kernel.

> Not that it matters; I suspect the driver isn't trying to load it at
> all. Can you test this patch, please?

Unfortunately, it doesn't help.  The driver either oopses or just doesn't work
(I don't know what exactly causes it to oops, although that only happens during
boot).

However, Ingo wrote that

" the firmware image, if i compare the before and after tg3FwText 
hex dump is blatantly different. Is this some different format, or did 
the "convert to request_firmware()" commit also embed an undocumented 
version jump in the binary blob that is loaded to your card? "

May this be the source of the problem?

Rafael

  parent reply	other threads:[~2008-06-27 23:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26 15:08 linux-next: Tree for June 26 Stephen Rothwell
     [not found] ` <20080627010842.e1a0c4b5.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2008-06-26 23:38   ` Rafael J. Wysocki
     [not found]     ` <200806270138.53895.rjw-KKrjLPT3xs0@public.gmane.org>
2008-06-27  9:28       ` David Woodhouse
2008-06-27 10:51     ` David Woodhouse
2008-06-27 12:42       ` Kamalesh Babulal
2008-06-27 12:48         ` David Woodhouse
     [not found]       ` <1214563913.10393.180.camel-ZP4jZrcIevRpWr+L1FloEB2eb7JE58TQ@public.gmane.org>
2008-06-27 23:04         ` Rafael J. Wysocki [this message]
2008-06-28  9:54           ` Jaswinder Singh
2008-06-28 10:32             ` David Woodhouse
     [not found]               ` <1214649164.10393.265.camel-ZP4jZrcIevRpWr+L1FloEB2eb7JE58TQ@public.gmane.org>
2008-06-29  0:15                 ` Rafael J. Wysocki
2008-06-29  8:01                   ` David Woodhouse
2008-06-29 11:36                     ` Rafael J. Wysocki
     [not found]                       ` <200806291336.44603.rjw-KKrjLPT3xs0@public.gmane.org>
2008-06-29 20:49                         ` David Woodhouse
2008-06-28 14:51             ` Ingo Molnar
2008-06-28 10:09           ` David Woodhouse
  -- strict thread matches above, loose matches on Subject: below --
2009-06-26  5:46 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806280104.17527.rjw@sisk.pl \
    --to=rjw-kkrjlpt3xs0@public$(echo .)gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public$(echo .)gmane.org \
    --cc=david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
    --cc=jaswinder-wEGCiKHe2LqWVfeAwA7xHQ@public$(echo .)gmane.org \
    --cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=macro-6z/3iImG2C8G8FEW9MqTrA@public$(echo .)gmane.org \
    --cc=mingo-X9Un+BFzKDI@public$(echo .)gmane.org \
    --cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public$(echo .)gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox