Subject: Re: [PATCH -next] fork and exit: need to include iocontext.h

From: Ingo Molnar <[email-masked]>
Date: Mon, 30 Jun 2008 20:47:35 +0200

* Randy Dunlap <[email-masked]> wrote:

> On Mon, 30 Jun 2008 20:33:37 +0200 Ingo Molnar wrote:
> 
> > 
> > * Randy Dunlap <[email-masked]> wrote:
> > 
> > > On Mon, 30 Jun 2008 20:05:06 +0200 Ingo Molnar wrote:
> > > 
> > > > 
> > > > * Randy Dunlap <[email-masked]> wrote:
> > > > 
> > > > > From: Randy Dunlap <[email-masked]>
> > > > > 
> > > > > Fix fork and exit build errors: they need to include iocontext.h:
> > > > > 
> > > > > linux-next-20080630/kernel/fork.c: In function 'copy_process':
> > > > > linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> > > > > linux-next-20080630/kernel/exit.c: In function 'do_exit':
> > > > > linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'
> > > > 
> > > > i havent seen this one - do you know by chance which commit triggers it?
> > > 
> > > 
> > > Sorry, no idea which commit.
> > > 
> > > In 50 randconfigs today (next-20080630), I saw this one 12 times.
> > 
> > btw., block.git would be one of my first guesses - Jens Cc:-ed.
> > 
> > normally there's an easy way to find out the source commit of build 
> > failures. Try something like:
> > 
> >  git-bisect reset
> >  git-bisect start
> >  git-bisect good v2.6.26-rc8
> >  git-bisect bad linux-next/master
> >  git-bisect run make kernel/fork.o
> > 
> > ... this should lead you to the commit that broke the build 
> > automatically. (as long as everyone keeps make oldconfig compatibility)
> 
> Thanks for the steps.  Maybe someday I'll use git.  ;)

goodies like this are the perfect receipe towards git-addiction ;-)

	Ingo