From: Mauro Carvalho Chehab <mchehab@infradead•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>, linux-next@vger•kernel.org
Subject: Fw: [linuxtv-commits] [hg:v4l-dvb] uvc: Fix compilation breakage for the other drivers, if uvc is selected
Date: Wed, 2 Jul 2008 09:06:43 -0300 [thread overview]
Message-ID: <20080702090643.60b8ce47@gaivota> (raw)
Hi Stephen,
I noticed a bad thing on a patch that I've added to linux-next. Basically, if
you select uvc, it will drop some other drivers. So, your today build is
probably incomplete.
I'm adding this patch to my linux-next tree.
The error and its fix is trivial.
It would be nice if we have a tool to get this error. I only noticed the
problem due to the large decrease of the compilation time.
Cheers,
Mauro.
------
From: Mauro Carvalho Chehab <mchehab@infradead•org>
uvc: Fix compilation breakage for the other drivers, if uvc is selected
UVC makefile defines obj as:
obj-$(CONFIG_USB_VIDEO_CLASS) := uvcvideo.o
Instead of:
obj-$(CONFIG_USB_VIDEO_CLASS) += uvcvideo.o
Due to that, if uvc is selected, all obj-y or obj-m that were added to
compilation were forget. This breaks a proper kernel build.
Acked-by: Laurent Pinchart <laurent.pinchart@skynet•be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead•org>
---
linux/drivers/media/video/uvc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -r d51bf59f63b5 -r 02cda7958a05 linux/drivers/media/video/uvc/Makefile
--- a/linux/drivers/media/video/uvc/Makefile Tue Jul 01 17:20:13 2008 -0300
+++ b/linux/drivers/media/video/uvc/Makefile Wed Jul 02 08:03:33 2008 -0300
@@ -1,3 +1,3 @@ uvcvideo-objs := uvc_driver.o uvc_queue
uvcvideo-objs := uvc_driver.o uvc_queue.o uvc_v4l2.o uvc_video.o uvc_ctrl.o \
uvc_status.o uvc_isight.o
-obj-$(CONFIG_USB_VIDEO_CLASS) := uvcvideo.o
+obj-$(CONFIG_USB_VIDEO_CLASS) += uvcvideo.o
---
Patch is available at: http://linuxtv.org/hg/v4l-dvb/rev/02cda7958a05b568b2851aeb88b57dba8fb77eb9
_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv•org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
Cheers,
Mauro
next reply other threads:[~2008-07-02 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 12:06 Mauro Carvalho Chehab [this message]
2008-07-03 4:45 ` Fw: [linuxtv-commits] [hg:v4l-dvb] uvc: Fix compilation breakage for the other drivers, if uvc is selected Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080702090643.60b8ce47@gaivota \
--to=mchehab@infradead$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox