From: Henrique de Moraes Holschuh <hmh@hmh•eng.br>
To: Matthew Garrett <mjg59@srcf•ucam.org>
Cc: Thomas Renninger <trenn@suse•de>,
ak@linux•intel.com, linux-acpi@vger•kernel.org,
linux-next@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>,
Julia Jomantaite <julia.jomantaite@gmail•com>,
marcus@better•se, dannybaumann@web•de, corsac@debian•org,
jesse.barnes@intel•com
Subject: Re: [PATCH 1/2] ACPI Video: Ignore devices that aren't present in hardware
Date: Fri, 4 Jul 2008 16:49:50 -0300 [thread overview]
Message-ID: <20080704194950.GA27898@khazad-dum.debian.net> (raw)
In-Reply-To: <20080704173910.GA16595@srcf.ucam.org>
On Fri, 04 Jul 2008, Matthew Garrett wrote:
> Got it. The reason for the delay is that BRTO sits in a loop for no
> obvious reason unless BRTF is cleared. The only thing that clears BRTF
> is the PWMS function, which isn't called anywhere in the ACPI tables.
> The NetBSD driver has the following code:
>
> /* Claim ownership of brightness control */
> param[0].Integer.Value = 0;
> (void)AcpiEvaluateObject(sc->sc_node->ad_handle, "PWMS", ¶ms, NULL);
>
> and doing this in thinkpad_acpi means my brightness control works in an
> acceptably speedy manner with opregion. Henrique, any thoughts on this?
> If you're happy with it, we can get opregion support into .27 and add
> the patch to remove duplicate ACPI video devices and everything will
> work in a beautiful and harmonious manner.
Well done!
Please give me one or two days to check the data I have and look over the
new DSDTs, and I will give you a better reply.
I really should go over the FreeBSD and NetBSD thinkpad drivers with a fine
comb looking over for stuff they figured out about the firmware that
thinkpad-acpi doesn't know about yet.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-07-04 19:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 16:05 [PATCH 1/2] ACPI Video: Ignore devices that aren't present in hardware Thomas Renninger
2008-07-03 16:08 ` Matthew Garrett
2008-07-03 16:15 ` Thomas Renninger
2008-07-03 16:16 ` Matthew Garrett
2008-07-03 16:21 ` Yves-Alexis Perez
2008-07-03 19:24 ` Matthew Garrett
2008-07-04 10:08 ` Thomas Renninger
2008-07-04 10:18 ` Matthew Garrett
2008-07-04 3:09 ` Henrique de Moraes Holschuh
2008-07-04 9:13 ` Matthew Garrett
2008-07-04 11:55 ` Henrique de Moraes Holschuh
2008-07-04 17:39 ` Matthew Garrett
2008-07-04 19:49 ` Henrique de Moraes Holschuh [this message]
2008-07-05 15:46 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080704194950.GA27898@khazad-dum.debian.net \
--to=hmh@hmh$(echo .)eng.br \
--cc=ak@linux$(echo .)intel.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=corsac@debian$(echo .)org \
--cc=dannybaumann@web$(echo .)de \
--cc=jesse.barnes@intel$(echo .)com \
--cc=julia.jomantaite@gmail$(echo .)com \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=marcus@better$(echo .)se \
--cc=mjg59@srcf$(echo .)ucam.org \
--cc=trenn@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox