From: Christian Borntraeger <borntraeger@de•ibm.com>
To: Jens Axboe <jens.axboe@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-s390@vger•kernel.org,
Heiko Carstens <heiko.carstens@de•ibm.com>
Subject: [PATCH linux-next] fix s390 compile error due to smp_call_function
Date: Tue, 8 Jul 2008 16:25:50 +0200 [thread overview]
Message-ID: <200807081625.50437.borntraeger@de.ibm.com> (raw)
Hello Jens,
the following patch in linux-next (v2.6.26-rc9-7220-g5e36ed1)
commit 8691e5a8f691cc2a4fda0651e8d307aaba0e7d68
Author: Jens Axboe <jens.axboe@oracle•com>
Date: Fri Jun 6 11:18:06 2008 +0200
smp_call_function: get rid of the unused nonatomic/retry argument
causes a build error on s390.
CC arch/s390/kernel/time.o
arch/s390/kernel/time.c: In function 'stp_work_fn':
arch/s390/kernel/time.c:1448: error: too many arguments to
function 'smp_call_function'
arch/s390/kernel/time.c:1481: error: too many arguments to
function 'smp_call_function'
The fix is simple and obvious, remove the unneeded argument.
Signed-off-by: Christian Borntraeger <borntraeger@de•ibm.com>
---
arch/s390/kernel/time.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-next/arch/s390/kernel/time.c
===================================================================
--- linux-next.orig/arch/s390/kernel/time.c
+++ linux-next/arch/s390/kernel/time.c
@@ -1445,7 +1445,7 @@ static void stp_work_fn(struct work_stru
*/
memset(&stp_sync, 0, sizeof(stp_sync));
preempt_disable();
- smp_call_function(clock_sync_cpu_start, &stp_sync, 0, 0);
+ smp_call_function(clock_sync_cpu_start, &stp_sync, 0);
local_irq_disable();
enable_sync_clock();
@@ -1478,7 +1478,7 @@ static void stp_work_fn(struct work_stru
stp_sync.in_sync = 1;
local_irq_enable();
- smp_call_function(clock_sync_cpu_end, NULL, 0, 0);
+ smp_call_function(clock_sync_cpu_end, NULL, 0);
preempt_enable();
}
next reply other threads:[~2008-07-08 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 14:25 Christian Borntraeger [this message]
2008-07-09 14:36 ` [PATCH linux-next] fix s390 compile error due to smp_call_function Heiko Carstens
2008-07-09 16:21 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807081625.50437.borntraeger@de.ibm.com \
--to=borntraeger@de$(echo .)ibm.com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=jens.axboe@oracle$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox