From: Adrian Bunk <bunk@kernel•org>
To: Heiko Carstens <heiko.carstens@de•ibm.com>,
Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Ingo Molnar <mingo@elte•hu>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH linux-next] Add module.h include to stacktrace.c.
Date: Wed, 16 Jul 2008 17:30:33 +0300 [thread overview]
Message-ID: <20080716143033.GD25557@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <20080711103925.GA20589@osiris.boeblingen.de.ibm.com>
Why was this patch ignored?
The build failures now made it into Linus' tree.
Stephen already fixed the powerpc one.
s390 is still broken.
And I just ran into this compile error on sh...
cu
Adrian
On Fri, Jul 11, 2008 at 12:39:25PM +0200, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@de•ibm.com>
>
> Fixes this:
>
> CC arch/s390/kernel/stacktrace.o
> arch/s390/kernel/stacktrace.c:84: warning: data definition has no type or storage class
> arch/s390/kernel/stacktrace.c:84: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/s390/kernel/stacktrace.c:84: warning: parameter names (without types) in function declaration
> arch/s390/kernel/stacktrace.c:97: warning: data definition has no type or storage class
> arch/s390/kernel/stacktrace.c:97: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> arch/s390/kernel/stacktrace.c:97: warning: parameter names (without types) in function declaration
>
> caused by "stacktrace: export save_stack_trace[_tsk]"
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de•ibm.com>
> ---
>
> Ingo, the patch which causes this came in via one of your trees.
> Please merge/apply. Thanks.
>
> arch/avr32/kernel/stacktrace.c | 1 +
> arch/mips/kernel/stacktrace.c | 1 +
> arch/powerpc/kernel/stacktrace.c | 1 +
> arch/s390/kernel/stacktrace.c | 1 +
> arch/sh/kernel/stacktrace.c | 1 +
> 5 files changed, 5 insertions(+)
>
> Index: linux-next/arch/s390/kernel/stacktrace.c
> ===================================================================
> --- linux-next.orig/arch/s390/kernel/stacktrace.c
> +++ linux-next/arch/s390/kernel/stacktrace.c
> @@ -10,6 +10,7 @@
> #include <linux/sched.h>
> #include <linux/stacktrace.h>
> #include <linux/kallsyms.h>
> +#include <linux/module.h>
>
> static unsigned long save_context_stack(struct stack_trace *trace,
> unsigned long sp,
> Index: linux-next/arch/avr32/kernel/stacktrace.c
> ===================================================================
> --- linux-next.orig/arch/avr32/kernel/stacktrace.c
> +++ linux-next/arch/avr32/kernel/stacktrace.c
> @@ -10,6 +10,7 @@
> #include <linux/sched.h>
> #include <linux/stacktrace.h>
> #include <linux/thread_info.h>
> +#include <linux/module.h>
>
> register unsigned long current_frame_pointer asm("r7");
>
> Index: linux-next/arch/mips/kernel/stacktrace.c
> ===================================================================
> --- linux-next.orig/arch/mips/kernel/stacktrace.c
> +++ linux-next/arch/mips/kernel/stacktrace.c
> @@ -7,6 +7,7 @@
> */
> #include <linux/sched.h>
> #include <linux/stacktrace.h>
> +#include <linux/module.h
> #include <asm/stacktrace.h>
>
> /*
> Index: linux-next/arch/powerpc/kernel/stacktrace.c
> ===================================================================
> --- linux-next.orig/arch/powerpc/kernel/stacktrace.c
> +++ linux-next/arch/powerpc/kernel/stacktrace.c
> @@ -12,6 +12,7 @@
>
> #include <linux/sched.h>
> #include <linux/stacktrace.h>
> +#include <linux/module.h>
> #include <asm/ptrace.h>
>
> /*
> Index: linux-next/arch/sh/kernel/stacktrace.c
> ===================================================================
> --- linux-next.orig/arch/sh/kernel/stacktrace.c
> +++ linux-next/arch/sh/kernel/stacktrace.c
> @@ -12,6 +12,7 @@
> #include <linux/sched.h>
> #include <linux/stacktrace.h>
> #include <linux/thread_info.h>
> +#include <linux/module.h>
> #include <asm/ptrace.h>
>
> /*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-07-16 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 10:39 [PATCH linux-next] Add module.h include to stacktrace.c Heiko Carstens
2008-07-16 14:30 ` Adrian Bunk [this message]
2008-07-16 15:35 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080716143033.GD25557@cs181140183.pp.htv.fi \
--to=bunk@kernel$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox