Subject: Re: linux-next: Tree for July 8 (HID)

From: Randy Dunlap <[email-masked]>
Date: Fri, 18 Jul 2008 15:37:32 -0700

On Wed, 9 Jul 2008 09:59:24 +0200 (CEST) Jiri Kosina wrote:

> On Tue, 8 Jul 2008, Randy Dunlap wrote:
> 
> > drivers/built-in.o: In function `usb_kbd_probe':
> > usbkbd.c:(.text+0x1457c9): undefined reference to `usbhid_lookup_quirk'
> > drivers/built-in.o: In function `usb_mouse_probe':
> > usbmouse.c:(.text+0x14603c): undefined reference to `usbhid_lookup_quirk'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> 
> This got introduced by Jiri's
> 
>  	HID: fix quirk handling in usbmouse/kbd
> 
> Added to CC (and added also Pascal).
> 
> The dependency of usbkbd/usbmouse on usbhid is strange anyway. I'd 
> probably remove the whole quirk lookup thing from usbkbd/usbmouse drivers. 
> They introduce this ugly dependency, which is not worth it I guess. Also 
> usbkbd/usbmouse drivers are not needed in the vast majority of cases 
> anyway, and they shouldn't be loaded in standard configurations at all.

Build error still present in linux-next 20080718.
Please fix it in some manner.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/