Subject: Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission

From: Al Viro <[email-masked]>
Date: Fri, 18 Jul 2008 18:23:08 +0100

On Fri, Jul 18, 2008 at 09:26:42AM -0700, Harvey Harrison wrote:
> Noticed by sparse
> > fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1153:16:    expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1153:16:    got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1172:16:    expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1172:16:    got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1184:16:    expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1184:16:    got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type
> > fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type
> > fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type
> 
> Signed-off-by: Harvey Harrison <[email-masked]>
> ---
> Appeared between next-20080716 and next-20080717
> 
>  fs/gfs2/ops_inode.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index 1e252df..0456e2b 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -915,8 +915,7 @@ int gfs2_permission(struct inode *inode, int mask)
>  	return error;
>  }
>  
> -static int gfs2_iop_permission(struct inode *inode, int mask,
> -			       struct nameidata *nd)
> +static int gfs2_iop_permission(struct inode *inode, int mask)
>  {
>  	return gfs2_permission(inode, mask);
>  }

Er?  Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function
completely; what tree are you working with?