From: Stephen Rothwell <sfr@canb•auug.org.au>
To: FUJITA Tomonori <fujita.tomonori@lab•ntt.co.jp>
Cc: mingo@elte•hu, joerg.roedel@amd•com, mingo@redhat•com,
tglx@linutronix•de, linux-kernel@vger•kernel.org,
iommu@lists•linux-foundation.org, bhavna.sarathy@amd•com,
robert.richter@amd•com, Linus <torvalds@linux-foundation•org>,
Andrew Morton <akpm@linux-foundation•org>,
Jesse Barnes <jbarnes@virtuousgeek•org>,
linux-next@vger•kernel.org
Subject: Re: [PATCH] add iommu_num_pages helper function
Date: Tue, 29 Jul 2008 13:56:52 +1000 [thread overview]
Message-ID: <20080729135652.f89042c1.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20080729104722H.fujita.tomonori@lab.ntt.co.jp>
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
Hi,
On Tue, 29 Jul 2008 10:46:31 +0900 FUJITA Tomonori <fujita.tomonori@lab•ntt.co.jp> wrote:
>
> > So, I assume a patch created on July 25 is not destined for 2.6.27,
>
> Hmm, seems that they will go into 2.6.27:
>
> http://marc.info/?l=linux-kernel&m=121729275722287&w=2
>
>
> > right? Especially since it breaks another architecture build and has
> > only made it to linux-next on July 29 ... and needs more work given the
> > comments already on this patch.
>
> It doesn't break another architecture build since only x86 IOMMUs use
> the helper function. But as I pointed out, it doesn't work for some
> architectures.
Um, did you see the linux-next build report I posted (possibly not):
arch/powerpc/kernel/iommu.c:56: error: static declaration of 'iommu_num_pages' follows non-static declaration
include/linux/iommu-helper.h:11: error: previous declaration of 'iommu_num_pages' was here
This is now a build of 2.6.27-rc1 for powerpc64 ppc64_defconfig ...
So we have a patch first posted to lkml on July 25 first hits linux-next
on July 29 and is no in Linus' tree on July 29. A grep would have found
the problem.
More care required ...
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next parent reply other threads:[~2008-07-29 3:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080725233325W.fujita.tomonori@lab.ntt.co.jp>
[not found] ` <20080726134156.GC4401@elte.hu>
[not found] ` <20080729110749.728c54e6.sfr@canb.auug.org.au>
[not found] ` <20080729104722H.fujita.tomonori@lab.ntt.co.jp>
2008-07-29 3:56 ` Stephen Rothwell [this message]
2008-07-29 4:38 ` [PATCH] add iommu_num_pages helper function FUJITA Tomonori
2008-07-29 5:26 ` David Miller
2008-07-29 5:42 ` FUJITA Tomonori
2008-07-29 5:24 ` David Miller
2008-07-29 5:42 ` FUJITA Tomonori
2008-07-29 6:45 ` Stephen Rothwell
2008-07-29 9:50 ` Joerg Roedel
2008-07-29 9:58 ` FUJITA Tomonori
2008-07-29 10:02 ` Joerg Roedel
2008-07-30 22:44 ` Benjamin Herrenschmidt
2008-07-31 2:07 ` FUJITA Tomonori
2008-07-29 10:10 ` David Miller
2008-07-29 10:26 ` Joerg Roedel
2008-07-29 10:27 ` FUJITA Tomonori
2008-07-29 10:31 ` Ingo Molnar
2008-07-29 10:33 ` David Miller
2008-07-29 12:45 ` Stephen Rothwell
2008-07-30 12:18 ` Joerg Roedel
2008-07-30 13:16 ` FUJITA Tomonori
2008-07-30 14:03 ` Joerg Roedel
2008-07-30 18:52 ` Joerg Roedel
2008-07-30 22:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729135652.f89042c1.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bhavna.sarathy@amd$(echo .)com \
--cc=fujita.tomonori@lab$(echo .)ntt.co.jp \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=joerg.roedel@amd$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=mingo@redhat$(echo .)com \
--cc=robert.richter@amd$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox