public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Andi Kleen <andi@firstfloor•org>, Len Brown <lenb@kernel•org>
Cc: linux-next@vger•kernel.org,
	Carlos Corbacho <carlos@strangeworlds•co.uk>,
	stable@kernel•org
Subject: linux-next: acpi tree build failure
Date: Tue, 12 Aug 2008 13:16:13 +1000	[thread overview]
Message-ID: <20080812131613.e3dfb2f5.sfr@canb.auug.org.au> (raw)

Hi all,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/misc/acer-wmi.c: In function 'set_u32':
drivers/misc/acer-wmi.c:831: error: 'status' undeclared (first use in this function)

Caused by commit 70ea586cc54ab2fb2af42d7ee97ba4f26e315f45 ("acer-wmi: Fix
wireless and bluetooth on early AMW0 v2 laptops").

Clearly, this hasn't even been build tested.  A bit more care, please.

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 12 Aug 2008 13:10:47 +1000
Subject: [PATCH] acpi: missing status declaration in acer-wmi.c

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 drivers/misc/acer-wmi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/acer-wmi.c b/drivers/misc/acer-wmi.c
index 894990f..6df52e8 100644
--- a/drivers/misc/acer-wmi.c
+++ b/drivers/misc/acer-wmi.c
@@ -812,6 +812,8 @@ static acpi_status get_u32(u32 *value, u32 cap)
 
 static acpi_status set_u32(u32 value, u32 cap)
 {
+	acpi_status status;
+
 	if (interface->capability & cap) {
 		switch (interface->type) {
 		case ACER_AMW0:
-- 
1.5.6.3

             reply	other threads:[~2008-08-12  3:16 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-12  3:16 Stephen Rothwell [this message]
2008-08-12  7:06 ` linux-next: acpi tree build failure Andi Kleen
2008-08-12 20:07   ` Carlos Corbacho
2008-08-12 21:29 ` Carlos Corbacho
  -- strict thread matches above, loose matches on Subject: below --
2008-10-15  4:51 Stephen Rothwell
2008-10-15  5:08 Stephen Rothwell
2008-10-15  5:15 ` Shaohua Li
2009-02-02  2:22 Stephen Rothwell
2009-02-05  2:13 ` Stephen Rothwell
2009-02-05  5:00   ` Greg KH
2009-02-07  4:06     ` Len Brown
2009-02-07  5:32       ` Greg KH
2009-02-24  4:37 Stephen Rothwell
2009-03-03  1:47 ` Stephen Rothwell
2009-03-16  5:10   ` Stephen Rothwell
2009-03-27 20:58   ` Len Brown
2009-03-18  0:57 Stephen Rothwell
2009-03-18  1:09 ` Lin Ming
2009-03-18  3:27   ` Stephen Rothwell
2009-03-27 20:49     ` Len Brown
2009-04-24  4:46 Stephen Rothwell
2009-04-24 15:15 ` Len Brown
2009-06-30  3:16 Stephen Rothwell
2009-07-06  6:18 ` Stephen Rothwell
2009-07-07  3:17 ` Len Brown
2009-07-07  3:53   ` Stephen Rothwell
2009-09-01  2:57 Stephen Rothwell
2009-09-07 13:46 ` Stephen Rothwell
2009-09-08  0:47   ` Zhang Rui
2009-09-09  4:02     ` Len Brown
2009-09-09  5:45       ` Stephen Rothwell
2009-09-26  2:15 Stephen Rothwell
2009-09-26  3:11 ` Bjorn Helgaas
2009-09-27  1:27   ` Crane Cai
2009-09-27  7:54     ` Len Brown
2009-12-14  1:20 Stephen Rothwell
2009-12-14 19:20 ` Bjorn Helgaas
2009-12-15  4:57 ` Bjorn Helgaas
2009-12-15 22:37   ` Len Brown
2009-12-15 23:28     ` Stephen Rothwell
2009-12-16  2:28     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080812131613.e3dfb2f5.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=andi@firstfloor$(echo .)org \
    --cc=carlos@strangeworlds$(echo .)co.uk \
    --cc=lenb@kernel$(echo .)org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=stable@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox