From: Jason Baron <jbaron@redhat•com>
To: Greg KH <greg@kroah•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>, linux-next@vger•kernel.org
Subject: Re: linux-next: driver-core tree build warning
Date: Mon, 18 Aug 2008 15:09:47 -0400 [thread overview]
Message-ID: <20080818190947.GA6200@redhat.com> (raw)
In-Reply-To: <20080816053432.GC20161@kroah.com>
On Fri, Aug 15, 2008 at 10:34:32PM -0700, Greg KH wrote:
> > Hi Greg,
> >
> > Today's linux-next build (x86_64 allmodconfig) produced this warning:
> >
> > In file included from include2/asm/string.h:4,
> > from include/linux/string.h:19,
> > from include/linux/dynamic_printk.h:4,
> > from include/linux/kernel.h:19,
> > from arch/x86/boot/memory.c:16:
> > include2/asm/string_64.h:34:1: warning: "memcpy" redefined
> > In file included from /scratch/sfr/next/arch/x86/boot/memory.c:15:
> > arch/x86/boot/boot.h:231:1: warning: this is the location of the previous definition
> >
> > Probably caused by commit 1b75321c2d0561d9ecfe3794fa939264f3eb7e26
> > ("driver core: basic infrastructure for per-module dynamic debug
> > messages") which added an include of linux/dynamic_printk.h to
> > linux/kernel.h.
>
> Wierd. Jason, any thoughts?
>
> thanks,
>
> greg k-h
hmm...i wasn't actually able to reproduce this (gcc 4.3.0-8), but I think I see
how this comes about. Anyways, we don't actually need to include "string.h",
its a remnant from an earlier version. The following patch should resolve this
issue.
thanks,
-Jason
Signed-off-by: Jason Baron <jbaron@redhat•com>
---
diff --git a/include/linux/dynamic_printk.h b/include/linux/dynamic_printk.h
index 210bf61..c54cf84 100644
--- a/include/linux/dynamic_printk.h
+++ b/include/linux/dynamic_printk.h
@@ -1,9 +1,6 @@
#ifndef _DYNAMIC_PRINTK_H
#define _DYNAMIC_PRINTK_H
-#include <linux/string.h>
-#include <linux/hash.h>
-
#define DYNAMIC_DEBUG_HASH_BITS 6
#define DEBUG_HASH_TABLE_SIZE (1 << DYNAMIC_DEBUG_HASH_BITS)
next prev parent reply other threads:[~2008-08-18 19:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 2:59 linux-next: driver-core tree build warning Stephen Rothwell
2008-08-16 5:34 ` Greg KH
2008-08-18 19:09 ` Jason Baron [this message]
2008-08-18 22:35 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2009-05-01 5:21 Stephen Rothwell
[not found] ` <20090501152144.500e619a.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-05-01 5:47 ` Greg KH
2009-05-01 6:11 ` Greg KH
2009-05-01 7:11 ` Stephen Rothwell
2009-07-13 7:26 Stephen Rothwell
2009-07-13 7:28 ` Stephen Rothwell
2009-07-13 7:51 ` Stephen Rothwell
2009-07-13 17:18 ` Greg KH
2009-07-13 21:23 ` David Brownell
2009-07-13 21:27 ` Greg KH
2009-07-13 21:36 ` Greg KH
2009-07-14 0:44 ` Stephen Rothwell
2010-01-19 6:27 Stephen Rothwell
2010-01-19 21:04 ` Greg KH
2010-01-19 23:45 ` Stephen Rothwell
2010-01-20 6:25 ` Stephen Rothwell
2010-01-20 6:44 ` Stephen Rothwell
2010-01-21 23:10 ` Greg KH
2010-01-21 23:20 ` Stephen Rothwell
2010-01-29 7:21 ` Stephen Rothwell
2010-02-03 2:22 ` Greg KH
2010-02-03 3:29 ` Stephen Rothwell
2010-02-04 7:10 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818190947.GA6200@redhat.com \
--to=jbaron@redhat$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox