From: Dmitry Torokhov <dmitry.torokhov@gmail•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, Greg KH <greg@kroah•com>,
"Alfred E. Heggestad" <aeh@db•org>
Subject: Re: linux-next: input tree build failure
Date: Tue, 19 Aug 2008 09:01:24 -0400 [thread overview]
Message-ID: <20080819084729.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080819163148.159c7d8c.sfr@canb.auug.org.au>
On Tue, Aug 19, 2008 at 04:31:48PM +1000, Stephen Rothwell wrote:
> Hi Dmitry,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/input/misc/cm109.c: In function 'cm109_usb_suspend':
> drivers/input/misc/cm109.c:768: error: implicit declaration of function 'info'
>
> Caused by commit c04148f915e5ba7947752e6348e0da4cdab1329e ("Input: add
> driver for USB VoIP phones with CM109 chipset") adding a usage of the info
> () function while commit 8aac48f4f2460b00468fd5f1101addf3df04e94c ("USB:
> remove info() macro from usb.h") from the usb tree removed it.
>
> I applied the following patch (which may not be the best).
Thank you Stephen, but I wonder if total removal of info() and warn()
is a good thing, since they provide standard way of outputting data
from modules when there is no device, i.e. at the time of driver
registration or removal.
Greg, do you think we could keep err, warn and info (maybe renaming to
dr_err, dr_warn and dr_info and probably moving them to kernel.h)
while still taking the parts of your patch that convert drivers to use
dev_* macros when possible?
--
Dmitry
next prev parent reply other threads:[~2008-08-19 13:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 6:31 linux-next: input tree build failure Stephen Rothwell
2008-08-19 13:01 ` Dmitry Torokhov [this message]
2008-08-19 19:59 ` Greg KH
2008-08-19 20:00 ` Greg KH
2008-08-20 5:49 ` Stephen Rothwell
2008-08-20 18:35 ` Greg KH
2008-08-22 20:29 ` Dmitry Torokhov
2008-08-22 22:15 ` Alfred E. Heggestad
2008-08-25 0:01 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2009-03-10 4:49 Stephen Rothwell
2009-03-10 5:02 ` Dmitry Torokhov
2009-03-10 5:14 ` Stephen Rothwell
2009-12-07 9:03 Stephen Rothwell
2009-12-07 16:25 ` Randy Dunlap
2009-12-07 17:36 ` Dmitry Torokhov
2009-12-07 22:16 ` Stephen Rothwell
2010-01-25 5:52 Stephen Rothwell
2010-01-25 6:46 ` Dmitry Torokhov
2010-01-25 7:26 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819084729.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail$(echo .)com \
--cc=aeh@db$(echo .)org \
--cc=greg@kroah$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox