From: Russell King <rmk+lkml@arm•linux.org.uk>
To: Takashi Iwai <tiwai@suse•de>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Randy Dunlap <randy.dunlap@oracle•com>,
sfr@canb•auug.org.au, sam@ravnborg•org,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
sameo@openedhand•com
Subject: Re: linux-next: Tree for August 19 (mfd/ucb)
Date: Wed, 20 Aug 2008 08:57:34 +0100 [thread overview]
Message-ID: <20080820075734.GA29002@flint.arm.linux.org.uk> (raw)
In-Reply-To: <s5h7iacnn15.wl%tiwai@suse.de>
On Wed, Aug 20, 2008 at 09:49:58AM +0200, Takashi Iwai wrote:
> At Tue, 19 Aug 2008 17:16:58 -0700,
> Andrew Morton wrote:
> >
> > On Tue, 19 Aug 2008 17:05:17 -0700
> > Randy Dunlap <randy.dunlap@oracle•com> wrote:
> >
> > > drivers/mfd/ucb1400 is a sound (AC97) driver, so it should depend
> > > on AC97_BUS, like in the patch below. However, with that patch in
> > > place, oldconfig goes belly up on me:
> > >
> > >
> > > linux-next-20080819> make ARCH=x86_64 O=X64 V=1 oldconfig
> > > make -C /local/linsrc/linux-next-20080819/X64 \
> > > KBUILD_SRC=/local/linsrc/linux-next-20080819 \
> > > KBUILD_EXTMOD="" -f /local/linsrc/linux-next-20080819/Makefile \
> > > oldconfig
> > > make -f /local/linsrc/linux-next-20080819/scripts/Makefile.build obj=scripts/basic
> > > /bin/sh /local/linsrc/linux-next-20080819/scripts/mkmakefile \
> > > /local/linsrc/linux-next-20080819 /local/linsrc/linux-next-20080819/X64 2 6
> > > GEN /local/linsrc/linux-next-20080819/X64/Makefile
> > > mkdir -p include/linux include/config
> > > make -f /local/linsrc/linux-next-20080819/scripts/Makefile.build obj=scripts/kconfig oldconfig
> > > scripts/kconfig/conf -o arch/x86/Kconfig
> > > make[2]: *** [oldconfig] Segmentation fault (core dumped)
> > > make[1]: *** [oldconfig] Error 2
> > > make: *** [sub-make] Error 2
> > >
> > >
> > >
> > > ---
> > > From: Randy Dunlap <randy.dunlap@oracle•com>
> > >
> > > mfd/ucb1400 sound driver uses/depends on AC97_BUS:
> > >
> > > ERROR: "ac97_bus_type" [drivers/mfd/ucb1400_core.ko] undefined!
> > >
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> > > cc: Samuel Ortiz <sameo@openedhand•com>
> > >
> > > ---
> > > drivers/mfd/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > --- linux-next-20080819.orig/drivers/mfd/Kconfig
> > > +++ linux-next-20080819/drivers/mfd/Kconfig
> > > @@ -52,6 +52,7 @@ config HTC_PASIC3
> > >
> > > config UCB1400_CORE
> > > tristate "Philips UCB1400 Core driver"
> > > + depends on AC97_BUS
> > > help
> > > This enables support for the Philips UCB1400 core functions.
> > > The UCB1400 is an AC97 audio codec.
> >
> > And this:
> >
> > From: Andrew Morton <akpm@linux-foundation•org>
> >
> > ia64 allmodconfig:
> >
> > In file included from include/linux/ucb1400.h:27,
> > from drivers/mfd/ucb1400_core.c:24:
> > include/asm-generic/gpio.h: In function `gpio_get_value_cansleep':
> > include/asm-generic/gpio.h:147: error: implicit declaration of function `gpio_get_value'
> > include/asm-generic/gpio.h: In function `gpio_set_value_cansleep':
> > include/asm-generic/gpio.h:153: error: implicit declaration of function `gpio_set_value'
> > drivers/mfd/ucb1400_core.c: At top level:
>
> This one is because the superfluous inclusion of <asm-generic/gpio.h>.
> Should have been fixed in the latest Russell's tree.
Haven't merged the two fixes discussed just yet - I only got a reply
from Stephen on his this morning.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-08-20 7:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 8:54 linux-next: Tree for August 19 Stephen Rothwell
2008-08-19 11:28 ` [PATCH next-20080819] drivers/usb/atm: Fix non-existing warn() Takashi Iwai
2008-08-19 20:02 ` Greg KH
[not found] ` <s5hiqtxw8en.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2008-08-20 0:47 ` Greg KH
[not found] ` <20080820004723.GB385-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-08-20 8:30 ` Takashi Iwai
2008-08-20 0:05 ` linux-next: Tree for August 19 (mfd/ucb) Randy Dunlap
2008-08-20 0:16 ` Andrew Morton
2008-08-20 2:25 ` KAMEZAWA Hiroyuki
2008-08-20 5:10 ` Randy.Dunlap
2008-08-20 7:49 ` Takashi Iwai
2008-08-20 7:57 ` Russell King [this message]
2008-08-20 8:00 ` Takashi Iwai
2008-08-20 8:53 ` Stephen Rothwell
2008-08-20 0:26 ` Andrew Morton
2008-08-20 4:21 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820075734.GA29002@flint.arm.linux.org.uk \
--to=rmk+lkml@arm$(echo .)linux.org.uk \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sam@ravnborg$(echo .)org \
--cc=sameo@openedhand$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox