public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Randy Dunlap <randy.dunlap@oracle•com>
To: Peter Oruba <peter.oruba@amd•com>
Cc: x86@kernel•org, linux-next@vger•kernel.org,
	akpm <akpm@linux-foundation•org>
Subject: [PATCH -next] microcode_amd: fix shift warning
Date: Thu, 21 Aug 2008 13:43:51 -0700	[thread overview]
Message-ID: <20080821134351.2b19ac2d.randy.dunlap@oracle.com> (raw)

From: Randy Dunlap <randy.dunlap@oracle•com>

microcode_amd.c uses ">> 32" on a 32-bit value, so gcc warns about that.
The code could use something like this *untested* patch.

linux-next-20080821/arch/x86/kernel/microcode_amd.c:229: warning: right shift count >= width of type

Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
---
 arch/x86/kernel/microcode_amd.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-next-20080821.orig/arch/x86/kernel/microcode_amd.c
+++ linux-next-20080821/arch/x86/kernel/microcode_amd.c
@@ -216,6 +216,7 @@ static void apply_microcode_amd(int cpu)
 	unsigned int rev;
 	int cpu_num = raw_smp_processor_id();
 	struct ucode_cpu_info *uci = ucode_cpu_info + cpu_num;
+	unsigned long addr;
 
 	/* We should bind the task to the CPU */
 	BUG_ON(cpu_num != cpu);
@@ -225,10 +226,9 @@ static void apply_microcode_amd(int cpu)
 
 	spin_lock_irqsave(&microcode_update_lock, flags);
 
-	edx = (unsigned int)(((unsigned long)
-			      &(uci->mc.mc_amd->hdr.data_code)) >> 32);
-	eax = (unsigned int)(((unsigned long)
-			      &(uci->mc.mc_amd->hdr.data_code)) & 0xffffffffL);
+	addr = (unsigned long)&uci->mc.mc_amd->hdr.data_code;
+	edx = (unsigned int)(((unsigned long)upper_32_bits(addr)));
+	eax = (unsigned int)(((unsigned long)lower_32_bits(addr)));
 
 	asm volatile("movl %0, %%ecx; wrmsr" :
 		     : "i" (0xc0010020), "a" (eax), "d" (edx) : "ecx");


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

next             reply	other threads:[~2008-08-21 20:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 20:43 Randy Dunlap [this message]
2008-08-22  4:55 ` [PATCH -next] microcode_amd: fix shift warning Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080821134351.2b19ac2d.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle$(echo .)com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=peter.oruba@amd$(echo .)com \
    --cc=x86@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox