From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Ingo Molnar <mingo@elte•hu>
Cc: Steven Rostedt <rostedt@goodmis•org>,
Thomas Gleixner <tglx@linutronix•de>,
"H. Peter Anvin" <hpa@zytor•com>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] ftrace: objcopy version test for local symbols
Date: Tue, 26 Aug 2008 11:51:13 +1000 [thread overview]
Message-ID: <20080826115113.806cfe23.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20080826094627.5d627b5b.sfr@canb.auug.org.au>
Hi Ingo, Steve,
On Tue, 26 Aug 2008 09:46:27 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> On Mon, 25 Aug 2008 21:01:03 +0200 Ingo Molnar <mingo@elte•hu> wrote:
> >
> > applied to tip/tracing/ftrace, also have integrated it into
> > auto-ftrace-next. (without much testing - i hope it goes well)
>
> Looks ok at a first glance, but it may spam my build logs a bit ...
> Anyway, we will see.
I was right, it produces way to many messages :-(
I applied the following patch for now. It would be nice if this check
could be done once per build and warned about once as well.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
>From 54bc3035c76a242d14df554966110e5964b3eac3 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 26 Aug 2008 11:45:01 +1000
Subject: [PATCH] ftrace: silence overly verbose warning
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
scripts/recordmcount.pl | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index ee9e126..ef0c6db 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -262,12 +262,12 @@ sub update_funcs
# only use locals if objcopy supports globalize-symbols
if (!$use_locals) {
- print STDERR
- "$inputfile: WARNING: referencing local function " .
- "$ref_func for mcount\n" .
- "\tConsider upgrading objcopy to support the globalize-" .
- "symbols option.\n"
- if (!$local_warn_once++);
+# print STDERR
+# "$inputfile: WARNING: referencing local function " .
+# "$ref_func for mcount\n" .
+# "\tConsider upgrading objcopy to support the globalize-" .
+# "symbols option.\n"
+# if (!$local_warn_once++);
return;
}
$convert{$ref_func} = 1;
--
1.5.6.3
next prev parent reply other threads:[~2008-08-26 1:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 3:01 linux-next: ftrace tree build failure Stephen Rothwell
2008-08-25 6:09 ` Ingo Molnar
2008-08-25 16:42 ` Steven Rostedt
2008-08-25 16:46 ` Steven Rostedt
2008-08-25 18:52 ` [PATCH] ftrace: objcopy version test for local symbols Steven Rostedt
2008-08-25 19:01 ` Ingo Molnar
2008-08-25 23:46 ` Stephen Rothwell
2008-08-26 1:51 ` Stephen Rothwell [this message]
2008-08-26 2:34 ` Steven Rostedt
2008-08-26 3:25 ` [PATCH] ftrace: only warn once on old objcopy and local functions Steven Rostedt
2008-08-26 5:47 ` Stephen Rothwell
2008-08-26 20:53 ` Steven Rostedt
2008-08-27 17:02 ` [PATCH] ftrace: remove warning of " Steven Rostedt
2008-08-28 7:52 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826115113.806cfe23.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=rostedt@goodmis$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox