public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte•hu>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Geert Uytterhoeven <geert@linux-m68k•org>,
	linux-next@vger•kernel.org, Yinghai Lu <yhlu.kernel@gmail•com>
Subject: Re: linux-next: m68k build failure
Date: Thu, 28 Aug 2008 08:59:07 +0200	[thread overview]
Message-ID: <20080828065907.GD16186@elte.hu> (raw)
In-Reply-To: <20080828165004.4d833de6.sfr@canb.auug.org.au>


* Stephen Rothwell <sfr@canb•auug.org.au> wrote:

> Hi Geert,
> 
> The m68k allmodconfig build of linux-next (next-20080827) failed like
> this:
> 
> ERROR: "nr_irqs" [drivers/serial/serial_core.ko] undefined!
> ERROR: "nr_irqs" [drivers/serial/8250.ko] undefined!
> ERROR: "nr_irqs" [drivers/net/hamradio/baycom_ser_fdx.ko] undefined!
> 
> Introduced by the sparseirq tree.
> 
> nr_irqs is not exported for m68k.  I will add a patch to add the 
> export to linux-next today.

should be fixed by the patch below (also pushed out into the sparseirq 
tree). Thanks,

	Ingo

--------------->
>From 3af7043c57080f1ae7cd80c661d3e1308f164e1b Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte•hu>
Date: Thu, 28 Aug 2008 08:56:33 +0200
Subject: [PATCH] sparseirq: export nr_irqs on m68k/sparc/s390

Stephen Rothwell reported such build failures on m68k/sparc/s390:

> ERROR: "nr_irqs" [drivers/net/hamradio/baycom_ser_fdx.ko] undefined!
> ERROR: "nr_irqs" [drivers/net/3c59x.ko] undefined!

export nr_irqs on these architectures too.

Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Ingo Molnar <mingo@elte•hu>
---
 arch/m68k/kernel/ints.c |    1 +
 arch/s390/kernel/irq.c  |    1 +
 arch/sparc/kernel/irq.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/m68k/kernel/ints.c b/arch/m68k/kernel/ints.c
index d8aebfc..8dd5591 100644
--- a/arch/m68k/kernel/ints.c
+++ b/arch/m68k/kernel/ints.c
@@ -47,6 +47,7 @@
 #endif
 
 int nr_irqs = NR_IRQS;
+EXPORT_SYMBOL(nr_irqs);
 
 extern u32 auto_irqhandler_fixup[];
 extern u32 user_irqhandler_fixup[];
diff --git a/arch/s390/kernel/irq.c b/arch/s390/kernel/irq.c
index 14eb549..3624c4a 100644
--- a/arch/s390/kernel/irq.c
+++ b/arch/s390/kernel/irq.c
@@ -18,6 +18,7 @@
 #include <linux/profile.h>
 
 int nr_irqs = NR_IRQS;
+EXPORT_SYMBOL(nr_irqs);
 
 /*
  * show_interrupts is needed by /proc/interrupts.
diff --git a/arch/sparc/kernel/irq.c b/arch/sparc/kernel/irq.c
index 059598b..4b99e3c 100644
--- a/arch/sparc/kernel/irq.c
+++ b/arch/sparc/kernel/irq.c
@@ -57,6 +57,7 @@
 #endif /* SMP */
 
 int nr_irqs = NR_IRQS;
+EXPORT_SYMBOL(nr_irqs);
 
 unsigned long __raw_local_irq_save(void)
 {

  reply	other threads:[~2008-08-28  6:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28  6:50 linux-next: m68k build failure Stephen Rothwell
2008-08-28  6:59 ` Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-12-09  6:45 Stephen Rothwell
2008-12-09  8:00 ` David Miller
2008-12-09  8:50   ` Stephen Rothwell
2008-07-30  7:52 Stephen Rothwell
2008-07-30  7:54 ` Stephen Rothwell
2008-07-30  8:02 ` David Miller
2008-07-30  8:49   ` Sam Ravnborg
2008-08-01  5:37     ` Stephen Rothwell
2008-08-01 13:52       ` Geert Uytterhoeven
2008-08-01 20:41         ` Sam Ravnborg
2008-08-02  4:06           ` Stephen Rothwell
2008-08-03 20:00             ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080828065907.GD16186@elte.hu \
    --to=mingo@elte$(echo .)hu \
    --cc=geert@linux-m68k$(echo .)org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=yhlu.kernel@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox