Subject: Re: linux-next: rcu build warnings

From: "Paul E. McKenney" <[email-masked]>
Date: Fri, 29 Aug 2008 07:42:00 -0700

On Fri, Aug 29, 2008 at 07:19:48PM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> Commit cd95851785bcfe95fdf73689e8ecb5a1c5959231 ("rcu: fix classic RCU
> locking cleanup lockdep problem") from the sched tree used a long
> (instead of unsigned long) for the flags argument to
> spin_lock_irqsave/restore producing these warnings:
> 
> kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
> kernel/rcuclassic.c:719: warning: comparison of distinct pointer types lacks a cast
> kernel/rcuclassic.c:727: warning: comparison of distinct pointer types lacks a cast

Hello, Steve,

Commit 0cd418ddb1ee88df7d16d5df06cb2da68eceb9e4 from linux-2.6-tip in the
tip/core/rcu section addresses this problem.  Please accept my apologies
for the hassle!!!

							Thanx, Paul

commit 0cd418ddb1ee88df7d16d5df06cb2da68eceb9e4
Author: Hiroshi Shimamoto <[email-masked]>
Date:   Mon Aug 18 14:39:21 2008 -0700

    rcuclassic: fix compiler warning
    
    CC      kernel/rcuclassic.o
    kernel/rcuclassic.c: In function 'rcu_init_percpu_data':
    kernel/rcuclassic.c:705: warning: comparison of distinct pointer
types lacks
    kernel/rcuclassic.c:713: warning: comparison of distinct pointer
types lacks
    
    flags should be unsigned long.
    
    Signed-off-by: Hiroshi Shimamoto <[email-masked]>
    Signed-off-by: Ingo Molnar <[email-masked]>