public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Jason Wessel <jason.wessel@windriver•com>
Cc: linux-next@vger•kernel.org
Subject: linux-next: build warning
Date: Fri, 29 Aug 2008 18:14:33 +1000	[thread overview]
Message-ID: <20080829181433.78a5ae42.sfr@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi Jason,

The current linux-next build (x86_64 allmodconfig) gives this warning:

drivers/char/tty_io.c: In function 'tty_find_polling_driver':
drivers/char/tty_io.c:307: warning: passing argument 2 of 'strict_strtoul' makes integer from pointer without a cast
drivers/char/tty_io.c:307: warning: passing argument 3 of 'strict_strtoul' makes pointer from integer without a cast

Which points to an actual bug introduced by commit
8a89d640448c261c248594511c72db0569725058 ("kgdboc,tty: Fix tty polling
search to use name correctly") from the kgdb tree.

simple_strtol() and strict_strtoul() take different parameters and have
different return values.

Warnings are important!  Please take a more care.

I will revert that commit from linux-next for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2008-08-29  8:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29  8:14 Stephen Rothwell [this message]
2008-08-29 12:09 ` linux-next: build warning Jason Wessel
  -- strict thread matches above, loose matches on Subject: below --
2008-09-18 21:17 Stephen Rothwell
2008-09-27  1:17 ` Steven Rostedt
2008-10-16  6:04 Stephen Rothwell
2008-10-16 16:04 ` Greg KH
2008-11-24  6:38 Stephen Rothwell
2008-11-24  7:53 ` NeilBrown
2008-11-24  9:14   ` Stephen Rothwell
2022-10-10  3:41 Stephen Rothwell
2022-10-10  4:11 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080829181433.78a5ae42.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=jason.wessel@windriver$(echo .)com \
    --cc=linux-next@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox