From: Adrian Bunk <bunk@kernel•org>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Randy Dunlap <randy.dunlap@oracle•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Tree for September 1 (recordmcount.pl)
Date: Wed, 3 Sep 2008 09:44:18 +0300 [thread overview]
Message-ID: <20080903064416.GC4104@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <20080902232639.255efb4f.akpm@linux-foundation.org>
On Tue, Sep 02, 2008 at 11:26:39PM -0700, Andrew Morton wrote:
> On Mon, 1 Sep 2008 11:25:49 -0700 Randy Dunlap <randy.dunlap@oracle•com> wrote:
>
> > On Mon, 1 Sep 2008 19:19:46 +1000 Stephen Rothwell wrote:
> >
> > > Hi all,
> > >
> > > Changes since next-20080829:
> >
> > When using patch tarballs and applying that to kernel bases,
> > scripts/recordmcount.pl fails because it is not executable.
> > (Yes, I know, using the git would/should fix this.)
> >
> > Is there any way to make (new) scripts executable when using
> > tarballs?
> >
> > I'll handle it on a case-by-case basis for now.
> >
>
> I did this:
>
> From: Andrew Morton <akpm@linux-foundation•org>
>
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CC scripts/mod/empty.o
> /bin/sh: /usr/src/25/scripts/recordmcount.pl: Permission denied
>
> We shouldn't assume that files have their `x' bits set. There are various
> ways in which file permissions get lost, including use of patch(1).
>
> It might not be correct to assume that perl lives in $PATH?
scripts/recordmcount.pl starts with "#!/usr/bin/perl -w", which is an
even stronger assumption.
> Cc: Ingo Molnar <mingo@elte•hu>
> Cc: Sam Ravnborg <sam@ravnborg•org>
> Cc: Steven Rostedt <rostedt@goodmis•org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
> ---
>
> scripts/Makefile.build | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff -puN scripts/Makefile.build~kbuild-ftrace-dont-assume-that-scripts-recordmcountpl-is-executable scripts/Makefile.build
> --- a/scripts/Makefile.build~kbuild-ftrace-dont-assume-that-scripts-recordmcountpl-is-executable
> +++ a/scripts/Makefile.build
> @@ -199,8 +199,9 @@ cmd_modversions = \
> endif
>
> ifdef CONFIG_FTRACE_MCOUNT_RECORD
> -cmd_record_mcount = $(srctree)/scripts/recordmcount.pl "$(ARCH)" \
> - "$(OBJDUMP)" "$(OBJCOPY)" "$(CC)" "$(LD)" "$(NM)" "$(RM)" "$(MV)" "$(@)";
> +cmd_record_mcount = perl $(srctree)/scripts/recordmcount.pl \
> + "$(ARCH)" "$(OBJDUMP)" "$(OBJCOPY)" "$(CC)" "$(LD)" "$(NM)" "$(RM)" \
> + "$(MV)" "$(@)";
> endif
>
> define rule_cc_o_c
> _
>
>
> but I haven't been able to interest anyone in the patch yet.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2008-09-03 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 9:19 linux-next: Tree for September 1 Stephen Rothwell
2008-09-01 18:25 ` linux-next: Tree for September 1 (recordmcount.pl) Randy Dunlap
2008-09-03 6:26 ` Andrew Morton
2008-09-03 6:44 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080903064416.GC4104@cs181140183.pp.htv.fi \
--to=bunk@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox