From: Randy Dunlap <randy.dunlap@oracle•com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Andrew@sc8-sf-spam2-b•sourceforge.net,
e1000-devel@lists•sourceforge.net,
LKML <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org, "Kirsher,
Jeffrey T" <jeffrey.t.kirsher@intel•com>,
Morton <akpm@linux-foundation•org>, jgarzik <jgarzik@pobox•com>
Subject: Re: linux-next: Tree for September 4 (PATCH: IXGBE)
Date: Fri, 5 Sep 2008 22:36:34 -0700 [thread overview]
Message-ID: <20080905223634.7a05a2f5.randy.dunlap@oracle.com> (raw)
In-Reply-To: <36D9DB17C6DE9E40B059440DB8D95F5206120576@orsmsx418.amr.corp.intel.com>
On Fri, 5 Sep 2008 16:47:55 -0700 Brandeburg, Jesse wrote:
> Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle•com>
> >
> > ixgbe needs to be restricted to the same build config (m/y)
> > as DCA since it calls the dca_*() functions.
> >
> > ixgbe_main.c:(.text+0xd9c09): undefined reference to `dca3_get_tag'
> > ixgbe_main.c:(.text+0xd9cc9): undefined reference to `dca3_get_tag'
> > ixgbe_main.c:(.text+0xda5c1): undefined reference to
> > `dca_add_requester' ixgbe_main.c:(.text+0xda5d6): undefined reference
> > to `dca_remove_requester' text+0xdc162): undefined reference to
> > `dca_add_requester'
> > text+0xdc1d3): undefined reference to `dca_remove_requester'
> > ixgbe_main.c:(.init.text+0xa74b): undefined reference to
> > `dca_register_notify' ixgbe_main.c:(.devinit.text+0xa4ca): undefined
> > reference to `dca_add_requester' ixgbe_main.c:(.exit.text+0xd21):
> > undefined reference to `dca_unregister_notify'
> > ixgbe_main.c:(.devexit.text+0x72d): undefined reference to
> > `dca_remove_requester' make[1]: *** [.tmp_vmlinux1] Error 1
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> ...
> > + depends on PCI && INET && DCA
>
> Looks like you set IXGBE=y and CONFIG_DCA=m. This depends DCA option is
> not so great because if INTEL_IOATDMA is disabled (and therefore DCA is
> disabled) then ixgbe won't show up as an option.
>
> How about this instead, use a select INTEL_IOATDMA:
>
> inline is whitespace busted, sorry. attached is the patch.
OK, that works. Thanks.
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
next prev parent reply other threads:[~2008-09-06 5:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 9:36 linux-next: Tree for September 4 Stephen Rothwell
2008-09-04 11:52 ` Alan Cox
2008-09-04 12:51 ` Stephen Rothwell
2008-09-04 23:53 ` Andrew Morton
2008-09-05 0:07 ` David Woodhouse
2008-09-05 3:28 ` linux-next: Tree for September 4 (PATCH: SND_USB) Randy Dunlap
2008-09-05 6:10 ` Takashi Iwai
2008-09-05 3:41 ` linux-next: Tree for September 4 (PATCH: IXGBE) Randy Dunlap
2008-09-05 16:38 ` [E1000-devel] " Brandeburg, Jesse
2008-09-05 23:47 ` Brandeburg, Jesse
2008-09-06 5:36 ` Randy Dunlap [this message]
2008-09-05 4:44 ` linux-next: Tree for September 4 Andrew Morton
2008-09-05 10:56 ` Rafael J. Wysocki
2008-09-05 18:30 ` Andrew Morton
2008-09-06 11:25 ` Rafael J. Wysocki
2008-09-06 13:42 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905223634.7a05a2f5.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=Andrew@sc8-sf-spam2-b$(echo .)sourceforge.net \
--cc=akpm@linux-foundation$(echo .)org \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox