From: Stephen Rothwell <sfr@canb•auug.org.au>
To: James Bottomley <James.Bottomley@HansenPartnership•com>
Cc: linux-next@vger•kernel.org,
"Martin K. Petersen" <martin.petersen@oracle•com>
Subject: linux-next: scsi tree build failure
Date: Wed, 15 Oct 2008 17:49:16 +1100 [thread overview]
Message-ID: <20081015174916.6cc04bdb.sfr@canb.auug.org.au> (raw)
[Resent to get past vger's filters]
Hi James,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
drivers/scsi/sd.c:579:27: error: macro "sd_dif_op" passed 4 arguments, but takes just 3
drivers/scsi/sd.c: In function 'sd_prep_fn':
drivers/scsi/sd.c:578: error: 'sd_dif_op' undeclared (first use in this function)
Caused by commit 9e06688e7d60149cc9ef78ff29515c20186bb418 ("[SCSI] sd:
Correctly handle all combinations of DIF and DIX").
I added the following patch.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Wed, 15 Oct 2008 16:54:59 +1100
Subject: [PATCH] scsi: sd_dif_op has four parameters
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/scsi/sd.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
index a92b991..1347e00 100644
--- a/drivers/scsi/sd.h
+++ b/drivers/scsi/sd.h
@@ -106,7 +106,7 @@ extern void sd_dif_complete(struct scsi_cmnd *, unsigned int);
#else /* CONFIG_BLK_DEV_INTEGRITY */
-#define sd_dif_op(a, b, c) do { } while (0)
+#define sd_dif_op(a, b, c, d) do { } while (0)
#define sd_dif_config_host(a) do { } while (0)
#define sd_dif_prepare(a, b, c) (0)
#define sd_dif_complete(a, b) (0)
--
1.5.6.5
next reply other threads:[~2008-10-15 6:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 6:49 Stephen Rothwell [this message]
2008-10-15 12:27 ` linux-next: scsi tree build failure James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2009-06-15 2:17 Stephen Rothwell
2009-06-15 15:11 ` James Bottomley
2009-06-15 21:40 ` Benjamin Herrenschmidt
2009-06-16 2:24 ` James Bottomley
2009-04-02 5:49 Stephen Rothwell
2009-04-02 14:22 ` James Bottomley
2009-04-02 17:19 ` Robert Love
2009-04-02 18:23 ` James Bottomley
2009-04-03 0:26 ` Stephen Rothwell
2009-04-03 1:16 ` James Bottomley
2009-04-03 2:37 ` Stephen Rothwell
2009-03-16 10:39 Stephen Rothwell
2009-03-16 13:22 ` James Bottomley
2008-12-30 16:16 Stephen Rothwell
2008-12-30 16:30 ` James Bottomley
2008-12-15 14:37 Stephen Rothwell
2008-12-15 14:52 ` James Bottomley
2008-12-17 12:20 ` Stephen Rothwell
2008-12-21 3:30 ` Stephen Rothwell
2008-12-22 1:59 ` James Bottomley
2008-12-22 2:38 ` Stephen Rothwell
2008-07-07 12:25 Stephen Rothwell
2008-07-07 14:39 ` James Bottomley
2008-07-07 14:53 ` Robert Jennings
2008-07-07 22:05 ` Benjamin Herrenschmidt
2008-07-07 22:07 ` James Bottomley
2008-07-07 22:48 ` Benjamin Herrenschmidt
2008-07-07 22:00 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081015174916.6cc04bdb.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=martin.petersen@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox