Subject: Re: linux-next: vfs tree build failure

From: Dave Chinner <[email-masked]>
Date: Mon, 20 Oct 2008 18:13:38 +1100

On Mon, Oct 20, 2008 at 05:18:30PM +1100, Stephen Rothwell wrote:
> Hi Al,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> fs/xfs/linux-2.6/xfs_export.c: In function 'xfs_fs_get_parent':
> fs/xfs/linux-2.6/xfs_export.c:201: error: incompatible type for argument 1 of 'd_obtain_alias'
.....
> Signed-off-by: Stephen Rothwell <[email-masked]>
> ---
>  fs/xfs/linux-2.6/xfs_export.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/linux-2.6/xfs_export.c b/fs/xfs/linux-2.6/xfs_export.c
> index 263027f..dd71e86 100644
> --- a/fs/xfs/linux-2.6/xfs_export.c
> +++ b/fs/xfs/linux-2.6/xfs_export.c
> @@ -198,7 +198,7 @@ xfs_fs_get_parent(
>  	if (unlikely(error))
>  		return ERR_PTR(-error);
>  
> -	return d_obtain_alias(cip->i_vnode);
> +	return d_obtain_alias(&cip->i_vnode);
>  }

Hmmmm - looks like the VFS patches aren't using the correct
accessor function like the original code did. The fix should
be:

+	return d_obtain_alias(VFS_I(cip));

Cheers,

Dave.
-- 
Dave Chinner
[email-masked]