public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Richard Purdie <rpurdie@rpsys•net>
Cc: linux-next@vger•kernel.org, Pavel Machek <pavel@suse•cz>,
	Len Brown <len.brown@intel•com>,
	Andrew Morton <akpm@linux-foundation•org>
Subject: linux-next: leds tree build failure
Date: Tue, 21 Oct 2008 15:47:22 +1100	[thread overview]
Message-ID: <20081021154722.fa74b698.sfr@canb.auug.org.au> (raw)

Hi Richard,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/leds/leds-hp-disk.c: In function 'hpled_add':
drivers/leds/leds-hp-disk.c:101: error: invalid lvalue in assignment

Caused by commit 9c78ff6e65cad9f9fcf0bbde2bfbbf3a544fb704 ("leds: Add
driver for HP harddisk protection LEDs") from the leds tree inertacting
with commit db89b4f0dbab837d0f3de2c3e9427a8d5393afa3 ("ACPI: catch calls
of acpi_driver_data on pointer of wrong type") from the acpi tree.

I fixed it up (see below).

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 21 Oct 2008 15:44:45 +1100
Subject: [PATCH] leds/acpi: fix merge fallout from acpi_driver_data change

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 drivers/leds/leds-hp-disk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/leds/leds-hp-disk.c b/drivers/leds/leds-hp-disk.c
index d636280..53a25b1 100644
--- a/drivers/leds/leds-hp-disk.c
+++ b/drivers/leds/leds-hp-disk.c
@@ -98,7 +98,7 @@ static int hpled_add(struct acpi_device *device)
 	adev.device = device;
 	strcpy(acpi_device_name(device), DRIVER_NAME);
 	strcpy(acpi_device_class(device), ACPI_MDPS_CLASS);
-	acpi_driver_data(device) = &adev;
+	device->driver_data = &adev;
 
 	ret = led_classdev_register(NULL, &hpled_led);
 	return ret;
-- 
1.5.6.5

             reply	other threads:[~2008-10-21  4:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21  4:47 Stephen Rothwell [this message]
2008-10-21  8:19 ` linux-next: leds tree build failure Pavel Machek
2008-10-23 21:46 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081021154722.fa74b698.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=len.brown@intel$(echo .)com \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=pavel@suse$(echo .)cz \
    --cc=rpurdie@rpsys$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox