Subject: Re: [PTCH -next] i2o: fix kernel-doc warnings

From: Randy Dunlap <[email-masked]>
Date: Mon, 27 Oct 2008 13:58:19 -0700

On Mon, 27 Oct 2008 13:14:01 -0700
Andrew Morton <[email-masked]> wrote:

> On Wed, 22 Oct 2008 16:38:38 -0700
> Randy Dunlap <[email-masked]> wrote:
> 
> > From: Randy Dunlap <[email-masked]>
> > 
> > Fixup i2o kernel-doc warnings:
> > 
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'bdev'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'mode'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'disk'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'mode'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'bdev'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'mode'
> > 
> > Signed-off-by: Randy Dunlap <[email-masked]>
> > cc: Al Viro <[email-masked]>
> > ---
> >  drivers/message/i2o/i2o_block.c |   12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > --- linux-next-20081022.orig/drivers/message/i2o/i2o_block.c
> > +++ linux-next-20081022/drivers/message/i2o/i2o_block.c
> > @@ -567,8 +567,8 @@ static void i2o_block_biosparam(unsigned
> >  
> >  /**
> >   *	i2o_block_open - Open the block device
> > - *	@inode: inode for block device being opened
> > - *	@file: file to open
> > + *	@bdev: block device being opened
> > + *	@mode: file open mode
> >   *
> >   *	Power up the device, mount and lock the media. This function is called,
> >   *	if the block device is opened for access.
> > @@ -596,8 +596,8 @@ static int i2o_block_open(struct block_d
> >  
> >  /**
> >   *	i2o_block_release - Release the I2O block device
> > - *	@inode: inode for block device being released
> > - *	@file: file to close
> > + *	@disk: gendisk device being released
> > + *	@mode: file open mode
> >   *
> >   *	Unlock and unmount the media, and power down the device. Gets called if
> >   *	the block device is closed.
> > @@ -643,8 +643,8 @@ static int i2o_block_getgeo(struct block
> >  
> >  /**
> >   *	i2o_block_ioctl - Issue device specific ioctl calls.
> > - *	@inode: inode for block device ioctl
> > - *	@file: file for ioctl
> > + *	@bdev: block device being opened
> > + *	@mode: file open mode
> >   *	@cmd: ioctl command
> >   *	@arg: arg
> 
> From my reading this is needed in current mainline?

True.  Al's -next patch (git tree) was merged into mainline.

-- 
~Randy