Subject: Re: linux-next: build failure

From: David Miller <[email-masked]>
Date: Tue, 11 Nov 2008 01:18:27 -0800 (PST)

From: Stephen Rothwell <[email-masked]>
Date: Tue, 11 Nov 2008 19:10:42 +1100

> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> drivers/net/wireless/ath9k/main.c: At top level:
> drivers/net/wireless/ath9k/main.c:827: warning: conflicting types for 'ath_detach'
> drivers/net/wireless/ath9k/main.c:827: error: static declaration of 'ath_detach' follows non-static declaration
> drivers/net/wireless/ath9k/main.c:812: error: previous implicit declaration of 'ath_detach' was here

It only passed my allmodconfig tests on sparc64 because this code is
guarded by "CONFIG_RFKILL" but not "CONFIG_RFKILL_MODULE".

I wonder how many times that kind of error exists (checking FOO but
not FOO_MODULE) in the tree :-/

In any event, John please get me a fix for this at your next
opportunity.