From: David Miller <davem@davemloft•net>
To: a.beregalov@gmail•com
Cc: sparclinux@vger•kernel.org, linux-next@vger•kernel.org,
kenchen@google•com, mingo@elte•hu, adobriyan@gmail•com
Subject: Re: [PATCH] sparc64: add function save_stack_trace_tsk()
Date: Wed, 12 Nov 2008 13:49:20 -0800 (PST) [thread overview]
Message-ID: <20081112.134920.37006534.davem@davemloft.net> (raw)
In-Reply-To: <20081112134749.GD12456@orion>
From: Alexander Beregalov <a.beregalov@gmail•com>
Date: Wed, 12 Nov 2008 16:47:49 +0300
> Current -next does not build on sparc64:
> LD .tmp_vmlinux1
> fs/built-in.o: In function `proc_pid_stack':
> /home/alexb/linux-2.6/fs/proc/base.c:360: undefined reference to
> `save_stack_trace_tsk'
>
> ---
>
> Add function save_stack_trace_tsk() on sparc64.
>
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail•com>
This won't work as-is.
The save_stack_trace() function starts with the actual frame-pointer
register in the current cpu to start winding back the stack. So
when 'tsk' is not 'current' nothing will be saved. That's what this
bit of code is doing:
__asm__ __volatile__(
"mov %%fp, %0"
: "=r" (ksp)
);
fp = ksp + STACK_BIAS;
Also, "stack_trace_flush()" should only be run when current == tsk.
prev parent reply other threads:[~2008-11-12 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 13:47 [PATCH] sparc64: add function save_stack_trace_tsk() Alexander Beregalov
2008-11-12 14:13 ` Alexander Beregalov
2008-11-12 21:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112.134920.37006534.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=a.beregalov@gmail$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=kenchen@google$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=sparclinux@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox