public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte•hu>
To: Alan Cox <alan@lxorguk•ukuu.org.uk>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	Thomas Gleixner <tglx@linutronix•de>,
	"H. Peter Anvin" <hpa@zytor•com>,
	linux-next@vger•kernel.org, Steven Rostedt <srostedt@redhat•com>,
	Alan Cox <alan@redhat•com>
Subject: [PATCH] tracing, tty: fix warnings caused by branch tracing and tty_kref_get()
Date: Tue, 25 Nov 2008 13:19:56 +0100	[thread overview]
Message-ID: <20081125121956.GA26727@elte.hu> (raw)
In-Reply-To: <20081125102515.54282c0d@lxorguk.ukuu.org.uk>


* Alan Cox <alan@lxorguk•ukuu.org.uk> wrote:

> On Tue, 25 Nov 2008 13:38:28 +1100
> Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> 
> > Hi all,
> > 
> > Today's linux-next build (x86_64 allmodconfig) produced lots of these
> > warnings:
> > 
> > include/linux/tty.h:330: warning: '______f' is static but declared in inline function 'tty_kref_get' which is not static
> > 
> > Caused by commit 2bcd521a684cc94befbe2ce7d5b613c841b0d304 ("trace:
> > profile all if conditionals").  Something needs to be done about
> > this ...  maybe tty_kref_get needs to be "static inline" instead of
> > "extern inline"?
> 
> If someone from the ftrace crew can sort the problem out and send me 
> a diff for the ttydev tree that shouldn't be a problem, but really 
> it looks like a problem with ftrace as that can't be the only case 
> this happens surely ?

i've done quite wide build testing of it and tty.h seems to be the 
only affected file triggering a warning due to this. ('extern inline' 
has been eliminated from most of the kernel in recent cycles)

	Ingo

---------------->
From 14bfc987e395797dfe03e915e8b4c7fc9e5078e4 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte•hu>
Date: Tue, 25 Nov 2008 08:58:11 +0100
Subject: [PATCH] tracing, tty: fix warnings caused by branch tracing and tty_kref_get()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Stephen Rothwell reported tht this warning started triggering in
linux-next:

  In file included from init/main.c:27:
  include/linux/tty.h: In function ‘tty_kref_get’:
  include/linux/tty.h:330: warning: ‘______f’ is static but declared in inline function ‘tty_kref_get’ which is not static

Which gcc emits for 'extern inline' functions that nevertheless define
static variables. Change it to 'static inline', which is the norm
in the kernel anyway.

Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Ingo Molnar <mingo@elte•hu>
---
 include/linux/tty.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/tty.h b/include/linux/tty.h
index 3b8121d..eaec37c 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -325,7 +325,7 @@ extern struct class *tty_class;
  *	go away
  */
 
-extern inline struct tty_struct *tty_kref_get(struct tty_struct *tty)
+static inline struct tty_struct *tty_kref_get(struct tty_struct *tty)
 {
 	if (tty)
 		kref_get(&tty->kref);

      reply	other threads:[~2008-11-25 12:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25  2:38 linux-next: ftrace tree build warnings Stephen Rothwell
2008-11-25  2:44 ` Steven Rostedt
2008-11-25  8:00 ` Ingo Molnar
2008-11-25  8:17   ` Stephen Rothwell
2008-11-25 10:25 ` Alan Cox
2008-11-25 12:19   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081125121956.GA26727@elte.hu \
    --to=mingo@elte$(echo .)hu \
    --cc=alan@lxorguk$(echo .)ukuu.org.uk \
    --cc=alan@redhat$(echo .)com \
    --cc=hpa@zytor$(echo .)com \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=srostedt@redhat$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox