From: Ingo Molnar <mingo@elte•hu>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl•ca>
Cc: Jens Axboe <jens.axboe@oracle•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org,
Arnaldo Carvalho de Melo <acme@redhat•com>
Subject: Re: [PATCH] Blktrace : conversion to tracepoint define
Date: Wed, 26 Nov 2008 12:22:08 +0100 [thread overview]
Message-ID: <20081126112208.GB20601@elte.hu> (raw)
In-Reply-To: <20081126110631.GD14826@Krystal>
* Mathieu Desnoyers <mathieu.desnoyers@polymtl•ca> wrote:
> Here is the conversion to the new tracepoint API, which applies to
> -tip after the patch you just emailed.
>
> Mathieu
>
>
> Blktrace : conversion to tracepoint define
>
> Adapt declaration/definitions of blktrace tracepoints to the new
> tracepoint API.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl•ca>
> CC: Arnaldo Carvalho de Melo <acme@redhat•com>
> CC: 'Ingo Molnar' <mingo@elte•hu>
> CC: Jens Axboe <jens.axboe@oracle•com>
> CC: Arnaldo Carvalho de Melo <acme@redhat•com>
> CC: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> block/blk-core.c | 13 +++++++++++++
> block/elevator.c | 3 +++
> drivers/md/dm.c | 2 ++
> fs/bio.c | 2 ++
> include/trace/block.h | 34 +++++++++++++++++-----------------
> mm/bounce.c | 2 ++
> 6 files changed, 39 insertions(+), 17 deletions(-)
>
> Index: linux.trees.git/mm/bounce.c
> ===================================================================
> --- linux.trees.git.orig/mm/bounce.c 2008-11-26 05:49:40.000000000 -0500
> +++ linux.trees.git/mm/bounce.c 2008-11-26 05:50:08.000000000 -0500
> @@ -22,6 +22,8 @@
>
> static mempool_t *page_pool, *isa_page_pool;
>
> +DEFINE_TRACE(block_bio_bounce);
> +
> #ifdef CONFIG_HIGHMEM
> static __init int init_emergency_pool(void)
> {
> Index: linux.trees.git/fs/bio.c
> ===================================================================
> --- linux.trees.git.orig/fs/bio.c 2008-11-26 05:49:40.000000000 -0500
> +++ linux.trees.git/fs/bio.c 2008-11-26 05:50:25.000000000 -0500
> @@ -29,6 +29,8 @@
> #include <trace/block.h>
> #include <scsi/sg.h> /* for struct sg_iovec */
>
> +DEFINE_TRACE(block_split);
> +
> static struct kmem_cache *bio_slab __read_mostly;
heh, just did a similar patch :)
i moved the tracepoint definitions into a central place in
block/blktrace.c, not spread out in the block files - because some of
the tracepoints such as trace_block_remap() get used from multiple
places so there's no real "home" file for them.
Moving the tracepoint definitions into blktrace.c consolidates it
nicely without cluttering the various block/* files and ties their
presence to CONFIG_BLK_DEV_IO_TRACE as well.
Ingo
next prev parent reply other threads:[~2008-11-26 11:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 10:29 linux-next: block tree build failure Stephen Rothwell
2008-11-26 10:42 ` Ingo Molnar
2008-11-26 10:47 ` Jens Axboe
2008-11-26 11:06 ` [PATCH] Blktrace : conversion to tracepoint define Mathieu Desnoyers
2008-11-26 11:22 ` Ingo Molnar [this message]
2008-11-26 11:23 ` Ingo Molnar
2008-11-26 11:27 ` Mathieu Desnoyers
2008-11-26 11:37 ` Ingo Molnar
2008-11-26 11:56 ` Mathieu Desnoyers
2008-11-26 11:16 ` linux-next: block tree build failure Ingo Molnar
2008-11-26 11:20 ` Jens Axboe
2008-11-26 11:28 ` Ingo Molnar
2008-11-26 11:23 ` Mathieu Desnoyers
2008-11-26 11:25 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126112208.GB20601@elte.hu \
--to=mingo@elte$(echo .)hu \
--cc=acme@redhat$(echo .)com \
--cc=jens.axboe@oracle$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mathieu.desnoyers@polymtl$(echo .)ca \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox