From: Sam Ravnborg <sam@ravnborg•org>
To: Len Brown <lenb@kernel•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Len Brown <len.brown@intel•com>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Randy Dunlap <randy.dunlap@oracle•com>,
x86@kernel•org, linux-acpi@vger•kernel.org
Subject: Re: [RFC PATCH] x86: create drivers/x86/ from drivers/misc/
Date: Sat, 29 Nov 2008 08:38:16 +0100 [thread overview]
Message-ID: <20081129073816.GB8351@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0811281801520.24773@localhost.localdomain>
Comments below in case we stick to this drivers/x86 thing...
Sam
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 93224b5..b89db1e 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1904,6 +1904,8 @@ source "drivers/Kconfig"
>
> source "drivers/firmware/Kconfig"
>
> +source "drivers/x86/Kconfig"
> +
> source "fs/Kconfig"
Any chance we can have this in drivers/Kconfig?
Just wrap all of the file in an
if X86
.....
endif
So we keep all the drivers/ stuff in one Kconfig file and
not spread all over.
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index d1a47ad..a750519 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -171,6 +171,9 @@ ifeq ($(CONFIG_X86_32),y)
> drivers-$(CONFIG_FB) += arch/x86/video/
> endif
>
> +# x86 platform-specific drivers
> +drivers-y += drivers/x86/
> +
Can this be included in drivers/Makefile like this:
obj-$(CONFIG_X86) += x86/
Notice that parisc already do the same. (Yes they have
a drivers/parisc dir).
We shall try to visit our tree in natural order when we build
and such a rule breaks this.
Also it is good to keep drivers/ stuff in one place.
> +++ b/drivers/x86/Kconfig
> @@ -0,0 +1,290 @@
> +#
> +# X86 Platform Specific Drivers
> +#
> +
> +menuconfig X86_PLATFORM_DEVICES
> + bool "X86 Platform devices"
> + default y
> + ---help---
> + Say Y here to get to see options for device drivers for various
> + x86 platforms, including vendor-specific laptop extension drivers.
> + This option alone does not add any kernel code.
> +
> + If you say N, all options in this submenu will be skipped and disabled.
> +
> +if X86_PLATFORM_DEVICES
> +
> +config ACER_WMI
> + tristate "Acer WMI Laptop Extras (EXPERIMENTAL)"
spaces => tab
> +config ASUS_LAPTOP
> + tristate "Asus Laptop Extras (EXPERIMENTAL)"
> + depends on ACPI
spaces => tab
> +config FUJITSU_LAPTOP
> + tristate "Fujitsu Laptop Extras"
> + depends on ACPI
> + depends on INPUT
> + depends on BACKLIGHT_CLASS_DEVICE
> + ---help---
spaces => tab
> +config HP_WMI
> + tristate "HP WMI extras"
> + depends on ACPI_WMI
> + depends on INPUT
> + depends on RFKILL
> + help
> + Say Y here if you want to support WMI-based hotkeys on HP laptops and
spaces => tab
> + to read data from WMI such as docking or ambient light sensor state.
> +
> + To compile this driver as a module, choose M here: the module will
> + be called hp-wmi.
> +
> +config MSI_LAPTOP
> + tristate "MSI Laptop Extras"
> + depends on ACPI
> + depends on BACKLIGHT_CLASS_DEVICE
> + ---help---
spaces => tab
> diff --git a/drivers/x86/Makefile b/drivers/x86/Makefile
> new file mode 100644
> index 0000000..4f14f28
> --- /dev/null
> +++ b/drivers/x86/Makefile
> @@ -0,0 +1,17 @@
> +#
> +# x86 Platform-Specific Drivers
> +#
> +obj- := x86.o # Dummy rule to force built-in.o to be made
This is not needed. I can see divers/misc uses the same
but it is bogus.
Sam
next prev parent reply other threads:[~2008-11-29 7:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 10:36 linux-next: Tree for November 28 Stephen Rothwell
2008-11-28 15:17 ` next-2008-11-28: bfin vs cpumask fixlet Alexey Dobriyan
2008-12-01 4:47 ` Rusty Russell
2008-11-28 17:55 ` linux-next: Tree for November 28 (misc/tc1100) Randy Dunlap
2008-11-28 21:35 ` drivers/x86 (Was: Re: linux-next: Tree for November 28 (misc/tc1100)) Stephen Rothwell
2008-11-28 21:50 ` Len Brown
[not found] ` <alpine.LFD.2.00.0811281702570.24773@localhost.localdomain>
2008-11-28 22:09 ` [RFC PATCH] x86: create drivers/x86/ from drivers/misc/ Len Brown
2008-11-28 22:35 ` Sam Ravnborg
2008-11-28 23:16 ` Len Brown
2008-11-29 0:16 ` Henrique de Moraes Holschuh
2008-12-01 4:35 ` Len Brown
2008-11-29 1:00 ` Randy Dunlap
2008-11-29 7:23 ` Sam Ravnborg
2008-11-29 7:38 ` Sam Ravnborg [this message]
2008-12-01 5:00 ` Len Brown
2008-12-01 5:54 ` Sam Ravnborg
2008-12-01 6:02 ` [RFC PATCH v2] create drivers/platform/x86/ " Len Brown
2008-12-01 6:03 ` [PATCH 1/2] drivers/misc/Makefile, Kconfig: cleanup Len Brown
2008-12-01 7:41 ` Sam Ravnborg
2008-12-01 19:23 ` Len Brown
2008-12-01 6:05 ` [PATCH 2/2] create drivers/platform/x86/ from drivers/misc/ Len Brown
2008-12-01 7:48 ` [RFC PATCH v2] " Ingo Molnar
2008-12-01 19:12 ` Len Brown
2008-11-28 23:20 ` [RFC PATCH] x86: create drivers/x86/ " Len Brown
2008-12-01 4:49 ` Randy Dunlap
2008-11-29 9:34 ` drivers/x86 (Was: Re: linux-next: Tree for November 28 (misc/tc1100)) Ingo Molnar
2008-12-01 4:29 ` Len Brown
2008-11-30 23:44 ` next-2008-11-28 : can't mount UDF DVD Laurent Riffard
2008-12-01 0:18 ` Marcin Slusarz
2008-12-01 19:28 ` Laurent Riffard
2008-12-01 23:22 ` [PATCH] udf: fix default mode and dmode options handling Marcin Slusarz
2008-12-02 13:38 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081129073816.GB8351@uranus.ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=len.brown@intel$(echo .)com \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox