Subject: Re: linux-next: sparc tree build failure

From: Rusty Russell <[email-masked]>
Date: Tue, 2 Dec 2008 21:52:25 +1030

On Tuesday 02 December 2008 16:54:13 Stephen Rothwell wrote:
> Hi Dave,
>
> Today's linux-next build (sparc defconfig) failed like this:
>
> lib/find_next_bit.c: In function 'find_last_bit':
> lib/find_next_bit.c:183: error: implicit declaration of function '__fls'

Thanks Stephen... that's a surprise.

Dave, I think this is a sparc issue.

sparc: asm/bitops.h should define __fls

bitops_64.h includes the generic one; pretty sure 32 should too.

(Found by using __fls in generic code and breaking sparc defconfig build:
 thanks Stephen and linux-next!)

Signed-off-by: Rusty Russell <[email-masked]>

diff --git a/arch/sparc/include/asm/bitops_32.h b/arch/sparc/include/asm/bitops_32.h
--- a/arch/sparc/include/asm/bitops_32.h
+++ b/arch/sparc/include/asm/bitops_32.h
@@ -98,6 +98,7 @@ static inline void change_bit(unsigned l
 #include <asm-generic/bitops/sched.h>
 #include <asm-generic/bitops/ffs.h>
 #include <asm-generic/bitops/fls.h>
+#include <asm-generic/bitops/__fls.h>
 #include <asm-generic/bitops/fls64.h>
 #include <asm-generic/bitops/hweight.h>
 #include <asm-generic/bitops/lock.h>