Subject: Re: next-2008-12-04: vm.bio_inline_vecs

From: Jens Axboe <[email-masked]>
Date: Fri, 5 Dec 2008 09:44:11 +0100

On Fri, Dec 05 2008, Alexey Dobriyan wrote:
> Please, merge into 4d539d965767b98582fa9b7b57f51dbc0ab54fc4
> aka "bio: add experimental support for inlining a number of bio_vecs inside the bio"
> 
> kernel/sysctl.c:1233: error: 'bio_inline_vecs' undeclared here (not in a function)

Thanks, Randy Dunlap also made me aware of this fact. I'll update the
original patch.

> 
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -1227,6 +1227,7 @@ static struct ctl_table vm_table[] = {
>  		.extra2		= &one,
>  	},
>  #endif
> +#ifdef CONFIG_BLOCK
>  	{
>  		.ctl_name	= CTL_UNNUMBERED,
>  		.procname	= "bio_inline_vecs",
> @@ -1237,6 +1238,7 @@ static struct ctl_table vm_table[] = {
>  		.strategy	= &sysctl_intvec,
>  		.extra1		= &zero,
>  	},
> +#endif
>  /*
>   * NOTE: do not add new entries to this table unless you have read
>   * Documentation/sysctl/ctl_unnumbered.txt

-- 
Jens Axboe