From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Jens Axboe <jens.axboe@oracle•com>
Cc: Martin Schwidefsky <schwidefsky@de•ibm.com>,
linux-next@vger•kernel.org,
Stephen Rothwell <sfr@canb•auug.org.au>
Subject: Re: linux-next: "aio: make the lookup_ioctx() lockless" causes s390 build bug
Date: Sat, 6 Dec 2008 13:53:34 +0100 [thread overview]
Message-ID: <20081206125334.GA12040@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20081205220634.GR18255@kernel.dk>
On Fri, Dec 05, 2008 at 11:06:35PM +0100, Jens Axboe wrote:
> On Fri, Dec 05 2008, Heiko Carstens wrote:
> > Hi Jens,
> >
> > your patch "aio: make the lookup_ioctx() lockless" in linux-next
> > causes this build bug on s390:
> >
> > arch/s390/mm/pgtable.c: In function 's390_enable_sie':
> > arch/s390/mm/pgtable.c:266: error: invalid operands to binary || (have 'int' and 'struct hlist_head')
> > arch/s390/mm/pgtable.c:282: error: invalid operands to binary || (have 'int' and 'struct hlist_head')
> > make[1]: *** [arch/s390/mm/pgtable.o] Error 1
> > make: *** [arch/s390/mm] Error 2
> >
> > Could you please fix that? Thanks! ;)
>
> Something like this?
>
> diff --git a/arch/s390/mm/pgtable.c b/arch/s390/mm/pgtable.c
> index ef3635b..0767827 100644
> --- a/arch/s390/mm/pgtable.c
> +++ b/arch/s390/mm/pgtable.c
> @@ -263,7 +263,7 @@ int s390_enable_sie(void)
> /* lets check if we are allowed to replace the mm */
> task_lock(tsk);
> if (!tsk->mm || atomic_read(&tsk->mm->mm_users) > 1 ||
> - tsk->mm != tsk->active_mm || tsk->mm->ioctx_list) {
> + tsk->mm != tsk->active_mm || !hlist_empty(&tsk->mm->ioctx_list)) {
> task_unlock(tsk);
> return -EINVAL;
> }
> @@ -279,7 +279,7 @@ int s390_enable_sie(void)
> /* Now lets check again if something happened */
> task_lock(tsk);
> if (!tsk->mm || atomic_read(&tsk->mm->mm_users) > 1 ||
> - tsk->mm != tsk->active_mm || tsk->mm->ioctx_list) {
> + tsk->mm != tsk->active_mm || !hlist_empty(&tsk->mm->ioctx_list)) {
> mmput(mm);
> task_unlock(tsk);
> return -EINVAL;
Yes, exactly. Thanks!
next prev parent reply other threads:[~2008-12-06 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 16:41 linux-next: "aio: make the lookup_ioctx() lockless" causes s390 build bug Heiko Carstens
2008-12-05 22:06 ` Jens Axboe
2008-12-06 12:53 ` Heiko Carstens [this message]
2008-12-09 11:21 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081206125334.GA12040@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=jens.axboe@oracle$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox