From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
linux-s390@vger•kernel.org, schwidefsky@de•ibm.com,
Frank Blaschka <frank.blaschka@de•ibm.com>,
Ursula Braun <braunu@de•ibm.com>
Subject: Re: [BUILD-FAILURE] linux-next: next-20081210 - s390x - lcs drivers breaks with !CONFIG_IP_MULTICAST
Date: Wed, 10 Dec 2008 13:08:33 +0100 [thread overview]
Message-ID: <20081210120833.GA4586@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20081210111740.GA6107@linux.vnet.ibm.com>
On Wed, Dec 10, 2008 at 04:47:40PM +0530, Kamalesh Babulal wrote:
> Hi,
>
> next-20081210 randconfig kernel builds fails with !CONFIG_IP_MULTICAST
>
> drivers/s390/net/lcs.c: In function 'lcs_new_device':
> drivers/s390/net/lcs.c:2179: error: implicit declaration of function 'lcs_set_multicast_list'
> make[2]: *** [drivers/s390/net/lcs.o] Error 1
> make[1]: *** [drivers/s390/net] Error 2
> make: *** [drivers/s390] Error 2
Thanks for reporting!
This should do the trick:
---
drivers/s390/net/lcs.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/s390/net/lcs.c
===================================================================
--- linux-2.6.orig/drivers/s390/net/lcs.c
+++ linux-2.6/drivers/s390/net/lcs.c
@@ -69,7 +69,9 @@ static char debug_buffer[255];
static void lcs_tasklet(unsigned long);
static void lcs_start_kernel_thread(struct work_struct *);
static void lcs_get_frames_cb(struct lcs_channel *, struct lcs_buffer *);
+#ifdef CONFIG_IP_MULTICAST
static int lcs_send_delipm(struct lcs_card *, struct lcs_ipm_list *);
+#endif /* CONFIG_IP_MULTICAST */
static int lcs_recovery(void *ptr);
/**
@@ -1280,6 +1282,8 @@ out:
lcs_clear_thread_running_bit(card, LCS_SET_MC_THREAD);
return 0;
}
+#endif /* CONFIG_IP_MULTICAST */
+
/**
* function called by net device to
* handle multicast address relevant things
@@ -1287,6 +1291,7 @@ out:
static void
lcs_set_multicast_list(struct net_device *dev)
{
+#ifdef CONFIG_IP_MULTICAST
struct lcs_card *card;
LCS_DBF_TEXT(4, trace, "setmulti");
@@ -1294,9 +1299,9 @@ lcs_set_multicast_list(struct net_device
if (!lcs_set_thread_start_bit(card, LCS_SET_MC_THREAD))
schedule_work(&card->kernel_thread_starter);
+#endif /* CONFIG_IP_MULTICAST */
}
-#endif /* CONFIG_IP_MULTICAST */
static long
lcs_check_irb_error(struct ccw_device *cdev, struct irb *irb)
next prev parent reply other threads:[~2008-12-10 12:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 5:46 linux-next: Tree for December 10 Stephen Rothwell
2008-12-10 9:36 ` KOSAKI Motohiro
2008-12-10 12:05 ` [bug?] bio: add experimental support for inlining a number of bio_vecs inside the bio KOSAKI Motohiro
2008-12-10 12:12 ` Jens Axboe
2008-12-10 21:13 ` Andrew Morton
2008-12-11 7:32 ` Jens Axboe
2008-12-11 0:39 ` KOSAKI Motohiro
2008-12-10 9:39 ` linux-next: Tree for December 10 KOSAKI Motohiro
2008-12-10 11:21 ` KOSAKI Motohiro
2008-12-10 11:17 ` [BUILD-FAILURE] linux-next: next-20081210 - s390x - lcs drivers breaks with !CONFIG_IP_MULTICAST Kamalesh Babulal
2008-12-10 12:08 ` Heiko Carstens [this message]
2008-12-10 16:31 ` Kamalesh Babulal
2008-12-10 22:52 ` linux-next: Tree for December 10 Andrew Morton
2008-12-10 23:53 ` Rafael J. Wysocki
2008-12-11 0:38 ` Andrew Morton
2008-12-11 1:15 ` mpt fusion device warning 5 times KOSAKI Motohiro
2008-12-11 1:58 ` [PATCH] cpumask:cpumask_of_node-ia64 fix KOSAKI Motohiro
2008-12-11 4:09 ` [linux-next][PATCH] " KOSAKI Motohiro
2008-12-11 4:15 ` [PATCH] " Mike Travis
2008-12-11 4:31 ` Mike Travis
2008-12-11 4:53 ` KOSAKI Motohiro
2008-12-12 8:11 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210120833.GA4586@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=braunu@de$(echo .)ibm.com \
--cc=frank.blaschka@de$(echo .)ibm.com \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox