From: Ingo Molnar <mingo@elte•hu>
To: KOSAKI Motohiro <kosaki.motohiro@jp•fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Yinghai Lu <yhlu.kernel@gmail•com>,
LKML <linux-kernel@vger•kernel.org>,
linux-next <linux-next@vger•kernel.org>
Subject: Re: [mmotm and linux-next][PATCH] irq: enclose irq_desc_lock_class in CONFIG_LOCKDEP
Date: Tue, 16 Dec 2008 13:18:15 +0100 [thread overview]
Message-ID: <20081216121815.GA25019@elte.hu> (raw)
In-Reply-To: <2f11576a0812160345t1cca65eg34064dbbcafcd280@mail.gmail.com>
* KOSAKI Motohiro <kosaki.motohiro@jp•fujitsu.com> wrote:
> >> > actually, this breaks the build on !SPARSEIRQ because we will use that
> >> > class in the non-sparseirq case. So we've converted a build warning to
> >> > a build failure ;-)
> >>
> >> Please give me your .config and tell me your arch. my ia64 box (ia64 is
> >> !SPARSEIRQ) can build the akpm patch.
> >
> > The expected build failure is obvious from reading the code:
> >
> > #ifdef CONFIG_TRACE_IRQFLAGS
> > void early_init_irq_lock_class(void)
> > {
> > #ifndef CONFIG_SPARSE_IRQ
> > struct irq_desc *desc;
> > int i;
> >
> > for_each_irq_desc(i, desc) {
> > if (!desc)
> > continue;
> >
> > lockdep_set_class(&desc->lock, &irq_desc_lock_class);
> >
> > Note that it's an #ifndef sparseirq, not an #ifdef sparseirq condition.
>
> I see. thanks.
> It seems my first proposal is better.
>
> or, following #ifdef ?
>
> #if defined(CONFIG_SPARSE_IRQ) || defined(CONFIG_TRACE_IRQFLAGS)
>
> /*
> * lockdep: we want to handle all irq_desc locks as a single lock-class:
> */
> static struct lock_class_key irq_desc_lock_class;
instead of increasing the #ifdef jungle, how about removing some? For
example is this distinction:
> > #ifndef CONFIG_SPARSE_IRQ
really needed? We should use symmetric lock class annotations, regardless
of how irq_desc[] is laid out.
Ingo
next prev parent reply other threads:[~2008-12-16 12:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 8:08 [mmotm and linux-next][PATCH] irq: enclose irq_desc_lock_class in CONFIG_LOCKDEP KOSAKI Motohiro
2008-12-16 8:34 ` Andrew Morton
2008-12-16 10:18 ` Ingo Molnar
2008-12-16 10:23 ` Ingo Molnar
2008-12-16 11:15 ` KOSAKI Motohiro
2008-12-16 11:20 ` Ingo Molnar
2008-12-16 11:45 ` KOSAKI Motohiro
2008-12-16 12:18 ` Ingo Molnar [this message]
2008-12-16 12:58 ` KOSAKI Motohiro
2008-12-17 10:40 ` KOSAKI Motohiro
2008-12-18 13:36 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216121815.GA25019@elte.hu \
--to=mingo@elte$(echo .)hu \
--cc=akpm@linux-foundation$(echo .)org \
--cc=kosaki.motohiro@jp$(echo .)fujitsu.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=yhlu.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox