Subject: Re: linux-next: Tree for December 29 (fcoe/libfc)

From: Randy Dunlap <[email-masked]>
Date: Mon, 29 Dec 2008 19:53:58 -0800

On Tue, 30 Dec 2008 03:16:21 +1100 Stephen Rothwell wrote:

> Hi all,
> 
> Changes since 20081219:
> 
> Undropped tree:
> 	scci
> 	mtd
> 
> Dropped trees (temporarily):
> 	nfs (akpm request due to 2.6.30 features)
> 	kvm (build problem)
> 	rr (build poblem)
> 	semaphore-removal (due to unfixed conflicts against Linus' tree)
> 	cpu_alloc (build problem)
> 	audit (difficult conflicts)
> 
> Linus' tree had three build failures requiring patches and one requiring
> a revert.

>>From drivers/scsi/Kconfig:

config LIBFC
	tristate "LibFC module"
	depends on SCSI && SCSI_FC_ATTRS
	---help---
	  Fibre Channel library module

config FCOE
	tristate "FCoE module"
	depends on SCSI
	select LIBFC
	---help---
	  Fibre Channel over Ethernet module

Aside from being very skimpy help messages, nothing there requires
SCSI_FC_ATTRS to be enabled for FCOE, so when FCOE is enabled,
LIBFC is selected, and then bang:

ERROR: "scsi_is_fc_rport" [drivers/scsi/libfc/libfc.ko] undefined!
ERROR: "fc_remote_port_delete" [drivers/scsi/libfc/libfc.ko] undefined!
ERROR: "fc_remote_port_add" [drivers/scsi/libfc/libfc.ko] undefined!
ERROR: "fc_release_transport" [drivers/scsi/fcoe/fcoe.ko] undefined!
ERROR: "fc_remove_host" [drivers/scsi/fcoe/fcoe.ko] undefined!
ERROR: "fc_attach_transport" [drivers/scsi/fcoe/fcoe.ko] undefined!

config attached.

---
~Randy