Subject: Re: [BUILD_FAILURE] next-20090115 - s390x - mm/kmemleak.c

From: Heiko Carstens <[email-masked]>
Date: Thu, 15 Jan 2009 13:05:26 +0100

On Thu, Jan 15, 2009 at 11:55:40AM +0000, Catalin Marinas wrote:
> On Thu, 2009-01-15 at 12:20 +0100, Heiko Carstens wrote:
> > On Thu, Jan 15, 2009 at 04:05:04PM +0530, Kamalesh Babulal wrote:
> > > Hi Stephen,
> > > 
> > > 	next-20090115 allyesconfig build fails on s390x
> > > 
> > > mm/built-in.o: In function `kmemleak_scan':
> > > mm/kmemleak.c:977: undefined reference to `_sdata'
> > > make: *** [.tmp_vmlinux1] Error 1
> > 
> > A lot of architectures don't have _sdata definined in their linker scripts.
> > On s390 _sdata would be the same as _etext. But that is not necessarily true
> > for all architectures.
> 
> Kmemleak has only been tested on ARM and x86. I can add patches for the
> other architectures so that the compilation is fine but can't really run
> such kernels.

That would be nice. Fixing it so that it actually works (_if_ it does not)
can still be done later.

Btw. you have

/*
 * Stop the automatic memory scanning thread. This function must be called
 * with the kmemleak_mutex held.
 */
void stop_scan_thread(void)
{
...

but call the function unlocked from kmemleak_write. Looks like a bug ;)