From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: linux-next@vger•kernel.org, Prarit Bhargava <prarit@redhat•com>,
David Howells <dhowells@redhat•com>,
KOSAKI Motohiro <kosaki.motohiro@jp•fujitsu.com>,
LKML <linux-kernel@vger•kernel.org>,
linux-ia64 <linux-ia64@vger•kernel.org>,
Sam Ravnborg <sam@ravnborg•org>, Kyle McMartin <kyle@mcmartin•ca>,
Tony Luck <tony.luck@intel•com>,
Trond Myklebust <trond.myklebust@fys•uio.no>
Subject: linux-next: build problem with nfs tree (Was: Re: [mmotm][PATCH] fix ia64 build error)
Date: Fri, 16 Jan 2009 12:49:49 +1100 [thread overview]
Message-ID: <20090116124949.7828a559.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20090115093514.f3f6b8ff.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]
Hi Andrew,
On Thu, 15 Jan 2009 09:35:14 -0800 Andrew Morton <akpm@linux-foundation•org> wrote:
>
> On Thu, 15 Jan 2009 20:05:08 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@jp•fujitsu.com> wrote:
>
> > Applied after: linux-next.patch
> > ==
> > Subject: [PATCH] remove duplicate EXPORT_SYMBOL()
> > Impact: fix build error
> >
> > In past, ia64_ksyms.c had EXPORT_SYMBOL(copy_page) in wrong place.
> >
> > old code was
> >
> > #include <asm/uaccess.h>
> > EXPORT_SYMBOL(__copy_user);
> > EXPORT_SYMBOL(__do_clear_user);
> > EXPORT_SYMBOL(__strlen_user);
> > EXPORT_SYMBOL(__strncpy_from_user);
> > EXPORT_SYMBOL(__strnlen_user);
> > EXPORT_SYMBOL(copy_page);
> >
> > (but actually, copy_page is declared in asm/page.h)
> >
> > And recently, commit bdc2619ab95d45d434c16d5c216bc6243761f6fb insert
> > EXPORT_SYMBOL(copy_page) into correct place.
> >
> > then, duplicate EXPORT_SYMBOL create following build error.
> >
> > arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__kcrctab_copy_page'
> > arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__kcrctab_copy_page' was here
> > arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__kstrtab_copy_page'
> > arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__kstrtab_copy_page' was here
> > arch/ia64/kernel/ia64_ksyms.c:65: error: redefinition of '__ksymtab_copy_page'
> > arch/ia64/kernel/ia64_ksyms.c:43: error: previous definition of '__ksymtab_copy_page' was here
>
> Yes, this is a strange bug added by
>
> commit 7aed50e09223e7623c7ab826efd53f097bed2f73
> Author: Prarit Bhargava <prarit@redhat•com>
> AuthorDate: Sat Jan 10 02:25:44 2009 +0000
> Commit: David Howells <dhowells@redhat•com>
> CommitDate: Sat Jan 10 02:25:44 2009 +0000
>
> CacheFiles: Add missing copy_page export for ia64
>
> I don't see how it could have been tested :(
>
> I also don't know which linux-next tree added that commit. There's a
> way of working this out but I forgot it.
In gitk you can search backwards for a merge commit containing "sfr" :-)
I have dropped the nfs tree from linux-next for today.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next parent reply other threads:[~2009-01-16 1:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090115200315.EBE3.KOSAKI.MOTOHIRO@jp.fujitsu.com>
[not found] ` <20090115093514.f3f6b8ff.akpm@linux-foundation.org>
2009-01-16 1:49 ` Stephen Rothwell [this message]
2009-01-16 1:59 ` linux-next: build problem with nfs tree (Was: Re: [mmotm][PATCH] fix ia64 build error) Andrew Morton
2009-01-16 2:49 ` Stephen Rothwell
2009-01-16 3:41 ` KOSAKI Motohiro
2009-01-16 4:34 ` Stephen Rothwell
2009-01-16 22:15 ` Andrew Morton
2009-01-16 22:40 ` Stephen Rothwell
2009-01-16 22:49 ` Stephen Rothwell
2009-01-16 22:51 ` Andrew Morton
2009-01-17 4:43 ` David Howells
2009-01-17 5:00 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116124949.7828a559.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=dhowells@redhat$(echo .)com \
--cc=kosaki.motohiro@jp$(echo .)fujitsu.com \
--cc=kyle@mcmartin$(echo .)ca \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=prarit@redhat$(echo .)com \
--cc=sam@ravnborg$(echo .)org \
--cc=tony.luck@intel$(echo .)com \
--cc=trond.myklebust@fys$(echo .)uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox