From: Alexey Dobriyan <adobriyan@gmail•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org, wim@iguana•be
Subject: Re: linux-next: Tree for January 23 (drivers/watchdog/cpwd.c:411: error: 'inode' undeclared (first use in this function))
Date: Sat, 24 Jan 2009 00:21:26 +0300 [thread overview]
Message-ID: <20090123212126.GA4937@x200.localdomain> (raw)
In-Reply-To: <20090123184826.f2c91472.sfr@canb.auug.org.au>
On sparc:
drivers/watchdog/cpwd.c: In function 'cpwd_ioctl':
drivers/watchdog/cpwd.c:411: error: 'inode' undeclared (first use in this function)
drivers/watchdog/cpwd.c:411: error: (Each undeclared identifier is reported only once
drivers/watchdog/cpwd.c:411: error: for each function it appears in.)
drivers/watchdog/cpwd.c: In function 'cpwd_compat_ioctl':
drivers/watchdog/cpwd.c:483: warning: passing argument 1 of 'cpwd_ioctl' from incompatible pointer type
drivers/watchdog/cpwd.c:483: warning: passing argument 2 of 'cpwd_ioctl' makes integer from pointer without a cast
drivers/watchdog/cpwd.c:483: error: too many arguments to function 'cpwd_ioctl'
Signed-off-by: Alexey Dobriyan <adobriyan@gmail•com>
---
drivers/watchdog/cpwd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/watchdog/cpwd.c
+++ b/drivers/watchdog/cpwd.c
@@ -402,6 +402,7 @@ static int cpwd_release(struct inode *inode, struct file *file)
static long cpwd_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
{
+ struct inode *inode = file->f_path.dentry->d_inode;
static struct watchdog_info info = {
.options = WDIOF_SETTIMEOUT,
.firmware_version = 1,
@@ -480,7 +481,7 @@ static long cpwd_compat_ioctl(struct file *file, unsigned int cmd,
case WIOCSTOP:
case WIOCGSTAT:
lock_kernel();
- rval = cpwd_ioctl(file->f_path.dentry->d_inode, file, cmd, arg);
+ rval = cpwd_ioctl(file, cmd, arg);
unlock_kernel();
break;
next prev parent reply other threads:[~2009-01-23 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 7:48 linux-next: Tree for January 23 Stephen Rothwell
2009-01-23 20:34 ` linux-next: Tree for January 23 (kvm) Randy Dunlap
2009-01-28 9:51 ` Andrew Morton
2009-01-28 10:20 ` Alexander Graf
2009-02-04 13:55 ` Avi Kivity
2009-01-23 21:03 ` [PATCH] kmemtrace: fix printk format warnings Randy Dunlap
2009-01-23 21:21 ` Alexey Dobriyan [this message]
2009-01-23 21:46 ` linux-next: Tree for January 23 (9pnet_rdma) Richard Holden
2009-01-23 23:00 ` [patch -next] 9pnet_rdma build error Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123212126.GA4937@x200.localdomain \
--to=adobriyan@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=wim@iguana$(echo .)be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox