From: David Miller <davem@davemloft•net>
To: gorcunov@gmail•com
Cc: adobriyan@gmail•com, sfr@canb•auug.org.au,
linux-next@vger•kernel.org, ebiederm@xmission•com
Subject: Re: [PATCH] pppol2tp: stop using proc internals
Date: Mon, 26 Jan 2009 21:10:29 -0800 (PST) [thread overview]
Message-ID: <20090126.211029.116617007.davem@davemloft.net> (raw)
In-Reply-To: <20090125084718.GC8203@localhost>
From: Cyrill Gorcunov <gorcunov@gmail•com>
Date: Sun, 25 Jan 2009 11:47:18 +0300
> [Alexey Dobriyan - Sun, Jan 25, 2009 at 01:00:48AM +0300]
> | [PATCH] pppol2tp: stop using proc internals
> |
> | PDE_NET usage in driver code is a sign and, indeed, switching
> | to seq_open_net/seq_release_net saves code and fixes bogus things, like
> | user triggerabble BUG_ON(!net) after maybe_get_net, and NULLifying ->private.
> |
> | Signed-off-by: Alexey Dobriyan <adobriyan@gmail•com>
...
> Thanks a lot Alexey! I'll fix PPPoE too.
Applied, thanks everyone.
prev parent reply other threads:[~2009-01-27 5:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 6:15 linux-next: proc tree build failure Stephen Rothwell
2009-01-23 7:09 ` Cyrill Gorcunov
2009-01-23 18:48 ` Alexey Dobriyan
2009-01-23 19:26 ` Cyrill Gorcunov
2009-01-23 19:41 ` Cyrill Gorcunov
2009-01-23 20:26 ` Cyrill Gorcunov
2009-01-24 22:00 ` [PATCH] pppol2tp: stop using proc internals Alexey Dobriyan
2009-01-25 8:47 ` Cyrill Gorcunov
2009-01-27 5:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126.211029.116617007.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=adobriyan@gmail$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=gorcunov@gmail$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox